Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential memory leak #398

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chrisbanes
Copy link
Owner

commented Aug 14, 2019

Since we're now using a potentially longer lived scope for data operations (#397), we need to make sure we don't leak any ViewModel members.

Fixed by wrapping the ObservableLoadingCounter to a WeakReference.

@googlebot googlebot added the cla: yes label Aug 14, 2019

Fix potential memory leak
Since we're now using a potentially longer
lived scope for data operations (#397), we need
to make sure we don't leak any ViewModel members.

Fixed by wrapping the ObservableLoadingCounter
to a WeakReference.

@chrisbanes chrisbanes force-pushed the cb/mem-leak branch from 456485a to e74b5d4 Aug 14, 2019

@chrisbanes chrisbanes merged commit ad1ae06 into master Aug 14, 2019

2 checks passed

build_test_deploy Workflow: build_test_deploy
Details
cla/google All necessary CLAs are signed

@chrisbanes chrisbanes deleted the cb/mem-leak branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.