From 630caee0f0331b78d23ad43cd2ea7e94e2280720 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Wed, 6 Mar 2024 16:27:49 -0800 Subject: [PATCH] settings: For subtitle of selected language, repeat canonical self-name It looks odd to have an item where the title and subtitle are slightly different ways of naming the same thing. The canonical self-name is the one we've chosen by following organizations with a broad global contributor base like Wikipedia, so use that. (We could instead just omit the subtitle, but if we did, then all the rows in the list would have two lines of text except the selected row which would have just one. And that non-uniformity might look odd.) --- src/settings/SettingsScreen.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/SettingsScreen.js b/src/settings/SettingsScreen.js index 982594a86d..9eb1fc3904 100644 --- a/src/settings/SettingsScreen.js +++ b/src/settings/SettingsScreen.js @@ -135,7 +135,7 @@ export default function SettingsScreen(props: Props): Node { items={languages.map(l => ({ key: l.tag, title: noTranslation(l.selfname), - subtitle: l.name, + subtitle: l.tag === language ? noTranslation(l.selfname) : l.name, }))} onValueChange={value => { dispatch(setGlobalSettings({ language: value }));