Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for lost connection infinite loop #77

Merged
merged 6 commits into from Dec 29, 2012

Conversation

Projects
None yet
3 participants
Contributor

atorres757 commented Dec 28, 2012

Added the ability to retry establishing a connection to redis when the connection is lost. I also placed a sleep for 1 second before attempting to re-establish a connection. Our error logs were logging large amounts of the following error fwrite(): send of 51 bytes failed with errno=32 Broken pipe.

atorres757 added some commits Nov 1, 2012

Added a check to see if we have args before we attempt to access the …
…first item in the payload args to prevent an undefined index error.
Updated Redisent.php to attempt three reconnects to the redis server …
…before giving up. Also supressed fwrite errors.

kalmas commented on e4f39a6 Dec 28, 2012

Peer Reviewed. Looks good.

Owner

chrisboulton commented Dec 29, 2012

Awesome, thanks 👍.

I actually fixed this a little differently here a while ago but haven't merged back my changes from our customisations. (😞)

Anyway, more than happy to bring this across and in. Thanks again!

chrisboulton added a commit that referenced this pull request Dec 29, 2012

Merge pull request #77 from atorres757/fix-lost-connection
Fix for lost connection infinite loop

@chrisboulton chrisboulton merged commit 5fdc360 into chrisboulton:master Dec 29, 2012

1 check passed

default The Travis build passed
Details
Contributor

atorres757 commented Jan 3, 2013

No prob, glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment