Skip to content

Bugfix: workers on non-forking OSs read jobs from the queue, but never actually do any work on them. #93

Open
wants to merge 1 commit into from

3 participants

@Crashthatch

Change from $this->fork() to Resque::fork() in 6800fbe now returns -1 (not false) and this should be checked for.

@Crashthatch Crashthatch Bugfix for non-forking OSs where workers take from the queue, but nev…
…er actually do any work.

Change from $this->fork() to Resque::fork() in 6800fbe now returns -1 (not false) and this should be checked for.
ed1bcef
@danhunsaker

Seems to me that this would only be an issue on Windows or certain mobile/embedded devices - and I would hardly consider either of those ideal environments for anything near this intense. Virtual machine technology has come a great distance in recent years, and can easily provide access to a properly-forking OS on any system with a minimum of overhead. It may take some work to get your system properly set up for this kind of project, but that amount of work will still probably be less, in the long run, than that required to work around the limitations of Windows and embedded devices just to get something working.

@richardkmiller

+1 for this PR. I closed #94 because this one was here first and handles my case perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.