Set job timestamp to ISO 8601 format so it can be properly 'relatized' #95

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

richardkmiller commented Mar 12, 2013

This is a tiny thing, but resque-web wasn't showing relative dates, e.g. "just now", with the current date format. I changed it to ISO 8601 to play better with resque-web's jQuery relatize_date.

Owner

chrisboulton commented Mar 14, 2013

It looks like this was a change made to Resque a few months ago: defunkt/resque@df08385

Don't suppose you know if it's been released as such?

I'd like to bring this in, but it looks like a backwards incompatible change with older versions of Resque. I'd say 1.3 (next release) is the best one because there are already other compatibility breaking changes.

Thanks for this. 👍

Contributor

richardkmiller commented Mar 14, 2013

Interestingly, I changed the date format to ISO 8601 so it would work, not knowing that it was also being changed in [Ruby] Resque. We're using Resque 1.23.0 from Ubuntu 12.04 gems and that change is not yet present.

Releasing with 1.3 works for me.

Contributor

ruudk commented Mar 27, 2013

Can you please update your PR so that it also includes the timestamp set in lib/Resque/Failure/Redis.php?

$data->failed_at = date('c');

I'm using the dev-master version of PHP-Resque so I'd like to see this merged :)

ruudk referenced this pull request in michelsalib/BCCResqueBundle Mar 27, 2013

Merged

Removed date filter from failed_list.html.twig #43

richardkmiller added some commits Mar 27, 2013

@richardkmiller richardkmiller update the timestamp format in another location b42d8a1
@richardkmiller richardkmiller update the timestamp format in another location
f1ccf60
Contributor

richardkmiller commented Mar 27, 2013

@ruudk Thanks for the heads up! Done.

Contributor

danhunsaker commented Dec 18, 2013

1.3 is still looming. It would probably be good to define it and get the Internet working on churning out the code to get it released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment