getVttCss/getFullyQualifiedUrl wrongly joins URL #31
Comments
syeopite
added a commit
to syeopite/invidious
that referenced
this issue
Aug 8, 2023
An upstream problem with videojs-vtt-thumbnails means that URLs gets joined incorrectly on any instance where `domain`, `external_port` and `https_only` aren't set. This commit adds some logic with the 404 handler to mitigate this problem. This is however only a workaround. See: iv-org#3117 chrisboustead/videojs-vtt-thumbnails#31
syeopite
added a commit
to syeopite/invidious
that referenced
this issue
Sep 19, 2023
An upstream problem with videojs-vtt-thumbnails means that URLs gets joined incorrectly on any instance where `domain`, `external_port` and `https_only` aren't set. This commit adds some logic with the 404 handler to mitigate this problem. This is however only a workaround. See: iv-org#3117 chrisboustead/videojs-vtt-thumbnails#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This code in getVttCss does not join both parts according to normal URL joining behavior:
With
this.options.src = "https://invidious.example.org/api/v1/storyboards/W58r7oycUrA?height=90"andvttImageDef = "/sb/i/W58r7oycUrA/storyboard3_L2/M0.jpg?sqp=...#xywh=0,0,158,90"the expected joined result ishttps://invidious.example.org/sb/i/W58r7oycUrA/storyboard3_L2/M0.jpg?sqp=...#xywh=0,0,158,90but the actual result ishttps://invidious.example.org/api/v1/storyboards/sb/i/W58r7oycUrA/storyboard3_L2/M0.jpg?sqp=...#xywh=0,0,158,90.I'm not sure if that's intentional, but it seems broken to me. It also causes Invidious to fail displaying thumbnails when it isn't configured to return full URLs
In case this isn't intentional, couldn't just using
new URL(url, base)replacegetFullyQualifiedUrl?The text was updated successfully, but these errors were encountered: