Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

No diff == Default to delete #15

Closed
rking opened this Issue Oct 22, 2012 · 4 comments

Comments

Projects
None yet
2 participants

rking commented Oct 22, 2012

If there is no diff from the swpfile, it's basically a useless file, is it not?

So it would make sense if you could just hit <enter> and get the [Y]es to delete.

Owner

chrisbra commented Oct 22, 2012

On Mon, October 22, 2012 14:12, ☈king wrote:

If there is no diff from the swpfile, it's basically a useless file, is it
not?

So it would make sense if you could just hit <enter> and get the [Y]es
to delete.

It is a good idea.

I have not yet found out, why it sometimes
does not provide a Delete option, although the diff seems to indicate
that both files are equal. I'll try to fix that as well.

regards,
Christian

Owner

chrisbra commented Oct 23, 2012

Fixed with commit 5f7e4cd

@chrisbra chrisbra closed this Oct 23, 2012

chrisbra added a commit that referenced this issue Oct 23, 2012

fix issue #15
When differences are found, default will be to create a diff,
if no differences are found, default is to delete swapfile.

rking commented Oct 23, 2012

I like it!

One oddity, though:

I did like:

vim foo.txt

Then in another shell:

vim foo.txt

And it gave me the option to "delete" as default, so I said "Sure why not". Then the builtin swpfile dialog appeared and I hit 'e', but then the builting dialog appeared again.

I'm reproducing it without problem.

Owner

chrisbra commented Oct 23, 2012

should work now with commit a065f94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment