Please pull these two fixes. #8

Closed
wants to merge 2 commits into from

2 participants

@blueyed

I would appreciate it if you pulled the fixes this time instead of manually editing things again..

Should be easier given the Github interface, too.. :)

@chrisbra
Owner

I am not sure, this is the right approach. The temporary settings should still be set back to their original values.

@chrisbra
Owner

How can I pull only the second commit?

@chrisbra
Owner

looks good.

@chrisbra
Owner
@blueyed

Well, you still have not managed to cherry-pick/merge any of my commits..

Git is powerful and lets you easily cherry-pick or merge things, and you still edit them by hand.. :)
I just would like to be credited not only in commit logs or changelogs, but by actual commits - and apart from that, it should make life easier for you, too, once you get used to it.

It's no big deal, but would be just nice to be credited like that.

@chrisbra
Owner

It was a small commit. I downloaded your patch file and only applied the second part. That was not hard. I agree, that cherry picking would be nice, but I have never done that and finding out about it would have taken me longer.

Sorry, for not correctly crediting you. But I keep a note in the changelog.

@blueyed blueyed closed this Dec 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment