New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not reset original 'foldtext' #18

Closed
noahfrederick opened this Issue Aug 16, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@noahfrederick

noahfrederick commented Aug 16, 2013

Hi,

This plug-in blows away my custom foldtext setting. I notice it gets set in ftplugin/csv.vim and then restores Vim's default value in b:undo_ftplugin.

I'm not even sure why csv.vim touches foldtext. I vote for removing it altogether.

Thanks for your consideration.

@chrisbra

This comment has been minimized.

Show comment
Hide comment
@chrisbra

chrisbra Aug 16, 2013

Owner

On Fri, August 16, 2013 05:04, Noah Frederick wrote:

Hi,

This plug-in blows away my foldtext setting. I notice it gets set in
ftplugin/csv.vim and then restores Vim's default value in
b:undo_ftplugin.

I'm not even sure why csv.vim touches foldtext. I vote for removing it
altogether.

Thanks for your consideration.

It's local to the window and I like it that way.

But I add another configuration option if you don't like that.

regards,
Christian

Owner

chrisbra commented Aug 16, 2013

On Fri, August 16, 2013 05:04, Noah Frederick wrote:

Hi,

This plug-in blows away my foldtext setting. I notice it gets set in
ftplugin/csv.vim and then restores Vim's default value in
b:undo_ftplugin.

I'm not even sure why csv.vim touches foldtext. I vote for removing it
altogether.

Thanks for your consideration.

It's local to the window and I like it that way.

But I add another configuration option if you don't like that.

regards,
Christian

chrisbra added a commit that referenced this issue Aug 16, 2013

@chrisbra chrisbra closed this Aug 16, 2013

@noahfrederick

This comment has been minimized.

Show comment
Hide comment
@noahfrederick

noahfrederick Aug 16, 2013

Thanks. It still changes my fillchars from fold:\ (a space) to fold:-, but I can live with that.

noahfrederick commented Aug 16, 2013

Thanks. It still changes my fillchars from fold:\ (a space) to fold:-, but I can live with that.

vim-scripts added a commit to vim-scripts/csv.vim that referenced this issue Mar 28, 2014

Version 30
- |:CSVSubstitute| should substitute all matches in a column, when 'g' flag is given- Don't override 'fdt' setting (chrisbra/csv.vim#18, reported by Noah Frederick, thanks!)- Consistent Commands naming (chrisbra/csv.vim#19, reported by Noah Frederick, thanks!)- New Function |CSVField()| and |CSVCol()|- clean up function did not remove certain buffer local variables, possible error when calling Menu function to disable CSV menu- make |:CSVArrangeColumn| do not output the numer of substitutions happened (suggested by Caylan Larson, thanks!)- better cleaning up on exit, if Header windows were used- Let |:CSVVHeader| accept a number, of how many columns to show (suggested by Caylan Larson, thanks!)- better error-handling for |CSVFixed|- selection of inner/outer text objects  was wrong, reported by Ingo Karkat, thanks!)- errors, when using |:CSVAnalyze| and there were empty attributes- allow to left-align columns when using |:CSVArrangeColumn|- |SumCol_CSV| did not detect negative values- make <cr> in (Virtual-) Replace work as documented(automatically uploaded)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment