New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong Parameter in HiCol function #8

Merged
merged 2 commits into from Oct 4, 2011

Conversation

Projects
None yet
2 participants
@fanglingsu
Contributor

fanglingsu commented Oct 2, 2011

I Fixed the missed bang parameter in HiCol function. The second commit indents the code. For me the code was very hard to read, with the indentation I can read it better. Maybe we can use early breakout to shorten the code and parsetime.

For Example:

if Condition
foo
bar
else
return ''
endif

could be done as following:
if !Condition
return ''
endinf
foo
bar

chrisbra added a commit that referenced this pull request Oct 4, 2011

Merge pull request #8 from fanglingsu/master
Fixed wrong Parameter in HiCol function

@chrisbra chrisbra merged commit 387f5ba into chrisbra:master Oct 4, 2011

@chrisbra

This comment has been minimized.

Show comment
Hide comment
@chrisbra

chrisbra Oct 4, 2011

Owner

Looks good. I am merging now.

Owner

chrisbra commented Oct 4, 2011

Looks good. I am merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment