Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_x_is_y tests from git #60

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@anarcat
Copy link
Contributor

anarcat commented Nov 22, 2017

No description provided.

anarcat added a commit to anarcat/Git-Mediawiki that referenced this pull request Nov 22, 2017

anarcat added a commit to anarcat/Git-Mediawiki that referenced this pull request Nov 22, 2017

@chriscool

This comment has been minimized.

Copy link
Owner

chriscool commented Nov 27, 2017

Yeah, this LGTM. Thanks!

@chriscool chriscool merged commit 262398b into chriscool:master Nov 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anarcat anarcat deleted the anarcat:is_tests branch Nov 27, 2017

@anarcat

This comment has been minimized.

Copy link
Contributor Author

anarcat commented Nov 27, 2017

So I forgot to update this PR unfortunately, but there are two more tests missing that we're using in the Git-Mediawiki project, as you can see in our final commit: anarcat/Git-Mediawiki@06694fd#diff-1a3e5e27180742ac2f268d7df5e0d30bR99

Those are test_path_is_missing and test_i18ngrep, but there are probably a bunch more missing... (How) do you keep track of the updates from the git side?

@chriscool

This comment has been minimized.

Copy link
Owner

chriscool commented Nov 27, 2017

Updates from the Git side are made when someone needs something that has already been implemented on the Git side. So I would suggest sending another commit with the 2 functions that are missing.

@anarcat

This comment has been minimized.

Copy link
Contributor Author

anarcat commented Nov 27, 2017

okay, will do thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.