Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php optional #4

Merged
merged 2 commits into from May 7, 2013

Conversation

@ccoenen
Copy link
Contributor

commented Apr 22, 2013

This will allow another way of using impact.rb: You may now use the default config, but you need to remove the /api directory (rename is sufficient).

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2013

also: the second commit might be unrelated. I ran into 500 server error on windows.

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2013

i apparently got the second commit wrong, the first time around. It would only deliver one entity to me. Now it correctly displays the entitiy list.

chrisdarroch added a commit that referenced this pull request May 7, 2013

Merge pull request #4 from ccoenen/php-optional
The sinatra app will now respond to URLs ending in ".php"

@chrisdarroch chrisdarroch merged commit af6e199 into chrisdarroch:master May 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.