Permalink
Browse files

reversed 771b73d

  • Loading branch information...
1 parent 771b73d commit fef4025f877c743f69e4659da0bcc319880c98f8 @chrisdew committed Nov 19, 2012
Showing with 2 additions and 2 deletions.
  1. +2 −2 protobuf_for_node.cc
View
4 protobuf_for_node.cc
@@ -143,11 +143,11 @@ namespace protobuf_for_node {
from <<
"var x = arr[" << i << "]; "
"if(x !== undefined) this['" <<
- descriptor->field(i)->name() <<
+ descriptor->field(i)->camelcase_name() <<
"'] = x; ";
if (i > 0) to << ", ";
- to << "this['" << descriptor->field(i)->name() << "']";
+ to << "this['" << descriptor->field(i)->camelcase_name() << "']";
}
from << " }})";

1 comment on commit fef4025

@AdamMagaluk

I forgot add in my pull request my changes to unit test file.

Currently the unit test file assumes the names are converted to camel_case, though not technically a bug as it was stated in issue #20 but I think misleading or at least not documented enough.

Personally I would like to see the names be equivalent to names in the proto file, it just makes things consistent. Let me know what you think.

My latest push that changes the unit test file, all pass. AdamMagaluk@bbb6092

Please sign in to comment.