Return and accept strings for int64s #19

merged 1 commit into from Oct 29, 2012


None yet

2 participants

seishun commented Oct 27, 2012

In a previous PR I used Buffers primarily because a user might need to write the value to another Buffer (e.g. a TCP socket). However, I found out that the ref module provides writeInt64 functions that accept strings - and strings are infinitely more usable than Buffers.

@chrisdew chrisdew merged commit 18e89d6 into chrisdew:master Oct 29, 2012

I think this patch is well worth having, until we figure out a good way to parameterise return types. i.e. uint64 -> String | Number | Buffer and enum -> String | Number.

@seishun seishun deleted the unknown repository branch Dec 27, 2012
@seishun seishun restored the unknown repository branch Jun 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment