Skip to content

Added a Visual Studio 2013 build error fix from the official repository #38

Merged
merged 2 commits into from May 7, 2014

2 participants

@looterz
looterz commented Feb 7, 2014

Implemented the fix from revision 512 of the official SVN repository on google code that allows Visual Studio 2013 to build protobuf without issues.

Source:
https://code.google.com/p/protobuf/issues/detail?id=531

@looterz
looterz commented Feb 7, 2014

Added one more change to this branch, that completely fixes all build errors Visual Studio 2013 was generating for me.

@chrisdew
Owner

Can a second pair of eyes (with a Windows machine) try building this before I merge?

@looterz
looterz commented Apr 17, 2014

Guess nobody else has a windows machine? damn.

@chrisdew
Owner

I'll make sure this doesn't break the Linux build next week, and merge if it's OK.

@looterz
looterz commented Apr 18, 2014

Alright cool. This issue was the only problem I had when working with a project using node-protobuf a few months ago on a windows box, I figured I would submit the fix because its bound to happen to someone else eventually, thankfully the guys on google-groups already fixed it though.

@chrisdew chrisdew merged commit b3acd33 into chrisdew:master May 7, 2014
@looterz looterz deleted the unknown repository branch May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.