Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix errors on node v0.6 #2

Merged
merged 1 commit into from

3 participants

@airhorns

Tests now pass on node v0.6.0, v0.6.2. There was an error with calling a RegExp as a function, so I switched tracejs to use exec.

@chrisdickinson

Awesome, good catch!

@chrisdickinson chrisdickinson merged commit 9c2bba2 into from
@vjeux

Please, can you update the tracejs NPM package with this fix. node-qunit depends on tracejs and bugs with the latest nodejs version :)

Thanks

@chrisdickinson

Thanks for the heads-up. Totally slipped my mind. Should be bumped to 0.1.4 now on npm. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 trace.js
View
4 trace.js
@@ -208,8 +208,8 @@ var trace = function(err) {
match1, match2;
frames = stack.map(function(line) {
- match1 = err_re1(line);
- match2 = err_re2(line);
+ match1 = err_re1.exec(line);
+ match2 = err_re2.exec(line);
if(match1) {
return new Frame(match1[1], match1[2], parseInt(match1[3], 10), parseInt(match1[4], 10))
Something went wrong with that request. Please try again.