This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Replace jpegtran with mozjpeg #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I support this pr! |
I've actually being using this for a while and in my testing it looks like mozjpeg always re-encodes files which can result in a loss of quality. This behaviour could be what people want, in which case something like imagemin-jpeg-recompress might be a better fit, as it should attempt to do this with as little loss in quality as possible. Alternatively, using imagemin-jpegtran with progressive enabled would be fully lossless. While mozjpeg works fine for my personal use, it's probably not the best default option for everybody, so I should probably close this pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces the
imagemin-jpegtranplugin withimagemin-mozjpeg. This should result in smaller filesizes for jpegs and progressive encoding by default, closing issue #28.The mozjpeg defaults seem pretty sane from a run on my site, but exposing some of the options might be a nice improvement.