Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this works? #12

Closed
goodmind opened this issue Jan 30, 2019 · 5 comments
Closed

Does this works? #12

goodmind opened this issue Jan 30, 2019 · 5 comments

Comments

@goodmind
Copy link

I can only see .d.ts files

@goodmind
Copy link
Author

Also it should be .js.flow files not .flow.js

@chrisgervang
Copy link
Owner

chrisgervang commented Jan 30, 2019

It works, I'm cleaning up some of the flags in #11

Ah, thanks for pointing that out. I'll test .js.flow it in my projects to make sure it doesn't cause issues. I was able to get this to work as I expected with .flow.js.

Edit: Also, see flow examples in https://github.com/chrisgervang/flowtype-protoc-gen/tree/master/examples/flow/generated/proto

@chrisgervang
Copy link
Owner

If you wait for flow-typed/flow-typed#3108 then it'll be even more typed.

@goodmind
Copy link
Author

@chrisgervang I managed to workaround Message static methods problem, but still looks bad
image

@goodmind
Copy link
Author

It also still typechecks with static override, just errors on declaration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants