clean up and minor issues #5

Merged
merged 2 commits into from Jun 27, 2012

Conversation

Projects
None yet
2 participants
Collaborator

franz-josef-kaiser commented Jun 26, 2012

No description provided.

Looks like I deleted everything and added it back in, but it's just GitHub marking every line, where I changed from space to tab.

Is most of this just changing spaces to tabs? Why?

Yes, it's just changing leading spaces to tabs. This fixes alignment issues due to mixed spaces and tabs like for example here.

I'll send another pull request that fixes other readability issues with GitHub and adds consistency as well as it removes PHP 4 compatibility (wp doesn't support PHP4 any more) adds some other minor PHP5 fixes.

The pull requests after that, then will fix some issues, like for example having a centralized repo for all your local installations, that doesn't work with WP_CONTENT_DIR, but a local domain. See this WPSE question as an example.

Owner

chrisguitarguy commented Jun 26, 2012

K, I'll take a look later tonight and merge.

chrisguitarguy added a commit that referenced this pull request Jun 27, 2012

Merge pull request #5 from franz-josef-kaiser/master
Spaces to tabs and some minor cleanup.

@chrisguitarguy chrisguitarguy merged commit 2eaa64b into chrisguitarguy:master Jun 27, 2012

Owner

chrisguitarguy commented Jun 27, 2012

I'm a "softtab" sort of guy, but I'm okay with this for now. There might be an accidental :retab at some point in the future, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment