/newrustacean.com

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to current Amethyst examples #122

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ebkalderon @chriskrycho
@ebkalderon
Copy link
Contributor

ebkalderon commented Jan 23, 2019

Fixed

  • Update all links to Amethyst examples to point to v0.10.0 (the current version) instead of v0.9.0.

Please let me know whether you would like to cherry-pick any of the commits, in particular the feed.xml, as I don't know if it's automatically generated. Thanks for the fun and informative episode, Chris. Keep it up! 😄

ebkalderon added some commits Jan 23, 2019

@ebkalderon
Update outdated examples link for Amethyst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a064743
@ebkalderon
Update outdated link for Amethyst in feed.xml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cbde41a
@ebkalderon
Update outdated link for Amethyst in rust_1_32.rs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
97ac79d
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Owner

chriskrycho commented Jan 23, 2019

This is perfect – thank you so much!

@chriskrycho chriskrycho merged commit 1065b6b into chriskrycho:master Jan 23, 2019

@ebkalderon ebkalderon deleted the ebkalderon:update-amethyst-links branch Jan 23, 2019

@ebkalderon ebkalderon referenced this pull request Jan 24, 2019

Merged

Clean up README.md, update outdated link #1377

bors bot added a commit to amethyst/amethyst that referenced this pull request Jan 25, 2019

@bors[bot] @ebkalderon
Merge #1377 
1377: Clean up README.md, update outdated link r=ebkalderon a=ebkalderon

### Changed

* Fix up capitalization, grammar, and spelling mistakes in the README.md.
* Rephrase some awkward sentences.
* Replace reference to pong example with a link to the [Games Made With Amethyst](https://community.amethyst-engine.org/t/games-made-with-amethyst/134) thread on the forum.

### Fixed

* Update outdated examples link to point to 0.10.0 examples. This tripped up @chriskrycho in the Rust 1.32 episode of New Rustacean (see [this PR](chriskrycho/newrustacean.com#122) for the fix).

Co-authored-by: Eyal Kalderon <ebkalderon@gmail.com>
Loading status checks…
4b4dc5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment