Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

remove 'filters not in dimensions' check #22

Open
wants to merge 1 commit into from

1 participant

Christopher Kruse
Christopher Kruse

This check is not required by GA, and is useful for filtering without presenting the data filtered on. This addresses chrisle/gattica#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 22, 2012
  1. Christopher Kruse
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 10 deletions.
  1. +0 −10 lib/gattica/engine.rb
10 lib/gattica/engine.rb
View
@@ -255,16 +255,6 @@ def validate_and_clean(args)
end
end
- # make sure that the user is only trying to filter fields that are in dimensions or metrics
- if args[:filters]
- missing = args[:filters].find_all do |arg|
- !possible.include? arg.match(/^\w*/).to_s # get the name of the filter and compare
- end
- unless missing.empty?
- raise GatticaError::InvalidSort, "You are trying to filter by fields that are not in the available dimensions or metrics: #{missing.join(', ')}"
- end
- end
-
return args
end
Something went wrong with that request. Please try again.