Chris Lloyd chrislloyd

Organizations

@minefold @assemblymade @asm-helpful
chrislloyd commented on issue petehunt/jsxstyle#3
@chrislloyd

Could there be a hack (for the moment) where components specify their own size breakpoints (as props) and media queries are written out to force th…

chrislloyd opened pull request webpack/css-loader#47
@chrislloyd
Update Clean CSS to a less buggy version.
1 commit with 1 addition and 1 deletion
@chrislloyd
  • @chrislloyd f1a8b51
    Update Clean CSS to a less buggy version.
chrislloyd closed pull request assemblymade/meta#267
@chrislloyd
Refactor markup on new idea page
chrislloyd commented on pull request assemblymade/meta#267
@chrislloyd

Hey @lachlanjc I think this might just be moving complexity around for the sake of it. A couple of things: I don't really see that padding is some…

chrislloyd commented on pull request assemblymade/meta#275
@chrislloyd

hey @saddington if you revert the "meritocracy" change happy to give a :+1:

@chrislloyd
chrislloyd merged pull request assemblymade/meta#276
@chrislloyd
Switch to open-source Code Climate badge.
1 commit with 1 addition and 1 deletion
chrislloyd commented on pull request assemblymade/meta#275
@chrislloyd

(Also, welcome & hi!)

chrislloyd commented on pull request assemblymade/meta#275
@chrislloyd

Hey @saddington! Love the changes. However, I feel a little uncomfortable with the word "meritocracy". I feel your general point there but there lo…

@chrislloyd
  • @chrislloyd 0929722
    Set heroku app name for travis.
@chrislloyd
  • @chrislloyd 4fae247
    Add my auth token to travis.
@chrislloyd
chrislloyd commented on pull request assemblymade/meta#267
@chrislloyd

Hard for me to comment without seeing what you plan on implementing.

chrislloyd commented on pull request assemblymade/meta#266
@chrislloyd

I just pulled this down and it looks like border colors are off: Also, it looks like borders on the footer are extending wide: and the about page…

chrislloyd commented on pull request assemblymade/meta#267
@chrislloyd

Hrrm, that makes me nervous too. <Tile /> is very very simple and doesn't need much more extension. I'm not as worried about adding more markup to …

chrislloyd commented on pull request assemblymade/meta#268
@chrislloyd

I think the phase out of assets is probably good for the index, but I actually quite like the space on the Bounties page showing the previews. I th…

chrislloyd commented on pull request assemblymade/meta#267
@chrislloyd

This is a :-1: from me. The <Tile> component is used pretty widely around the site and is really important for reusability. It adds some extra markup …

@chrislloyd

The comment has since been removed.

chrislloyd commented on pull request assemblymade/meta#262
@chrislloyd

We're trying a format of one ":+1:" and somebody else merging the PR to ensure that 2 people have eyes on external PRs.

@chrislloyd
  • @chrislloyd cf387dc
    Update scss-lint config for Hound.
chrislloyd commented on pull request assemblymade/meta#266
@chrislloyd

Just looking into configuring Hound to Assembly style.

@chrislloyd
chrislloyd merged pull request assemblymade/meta#265
@chrislloyd
Remove owl tweet carousel
2 commits with 8 additions and 1,895 deletions