Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use length.out rather than by = 1 #12

merged 2 commits into from Oct 11, 2019


Copy link

aghaynes commented Oct 8, 2019

With larger datasets (e.g. denominator in the 100's of thousands), creating the CI matrix takes a long time.
This small change should improve speed for such datasets. Currently set to length.out = 1000, which should be sufficient for most uses... (could even make it an option...)

aghaynes added 2 commits Oct 8, 2019
should improve speed for larger datasets

This comment has been minimized.

Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
  Coverage   80.29%   80.29%           
  Files           5        5           
  Lines         274      274           
  Hits          220      220           
  Misses         54       54
Impacted Files Coverage Δ
R/build_limits_lookup.R 73.17% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79b897...5713e79. Read the comment docs.

@chrismainey chrismainey merged commit fc44538 into chrismainey:master Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 66.66% of diff hit (target 80.29%)
codecov/project 80.29% remains the same compared to 37b288a
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

chrismainey commented Oct 11, 2019

Thanks @aghaynes ! Makes a lot of sense. Keeps the size of the lookup data.frame the same regardless of input. By the time you get into large number, the limits don't change much either, so the gap between points should not affect anything. Tests passed and build correctly, so merged.


This comment has been minimized.

Copy link
Contributor Author

aghaynes commented Oct 11, 2019

You're welcome. 😄 I wasn't sure about the number to put... 1000 seems like a lot... maybe 500 or even 100 is enough... but I'll leave that decision up to you... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.