Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent error message in the 4th "koan" #71

Closed
urig opened this issue May 5, 2018 · 2 comments
Closed

Incoherent error message in the 4th "koan" #71

urig opened this issue May 5, 2018 · 2 comments

Comments

@urig
Copy link

urig commented May 5, 2018

I've completed the first three Koans successfully ("replace __ with ..." etc)
When I run the the project for the 4th koan (In VS Code with Ionide) I get the following stack trace:

I get:

You have not yet reached enlightenment ...
  Expected: <System.String>
  But was:  <FSharpKoans.Core.Helpers+FILL_ME_IN>


Please meditate on the following code:
   at NUnit.Framework.Assert.ReportFailure(String message)
   at NUnit.Framework.Assert.AreEqual(Object expected, Object actual)
   at FSharpKoans.Core.Helpers.AssertEquality[T](T x, T y) in C:\dev\ChrisMarinos\FSharpKoans\FSharpKoans.Core\Helpers.fs:line

17

The line referred to is:

let AssertEquality (x:'T) (y:'T) = Assert.AreEqual(x,y)

in Helpers.fs

This is because I did not replace FILL_ME_IN with the "string".

Kindly requesting that the error message given be made clearer and point to the failed Koan and not to the helper as it's quite confusing for newbies.

@urig urig changed the title Strange excception in the 4th "koan" Incoherent error message in the 4th "koan" May 5, 2018
@ChrisMarinos
Copy link
Owner

This should be fixed with #78 now.

@urig
Copy link
Author

urig commented Oct 9, 2018

@ChrisMarinos, @sgoodgrove and @normanhh3 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants