Skip to content

Loading…

Seems like a pretty simple fix, did the trick. #120

Merged
merged 1 commit into from

2 participants

@jacobSingh

Docs could also use something specifying that this will not work with standard getopt syntax, -mN does not work, only -m N. Similarly --max=N will not work.

Using the node getopt library seems like it would be useful here, no?

@chriso
Owner

Thanks for this. I implemented the opts parsing part of node.io before there were any libraries available to do it for you. I plan on bundling a dep in v2 which will use the standard getopt syntax.

@chriso chriso closed this
@chriso chriso reopened this
@chriso chriso merged commit 5e715f5 into chriso:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 2, 2012
  1. @jacobSingh
Showing with 1 addition and 0 deletions.
  1. +1 −0 lib/node.io/interfaces/cli.js
View
1 lib/node.io/interfaces/cli.js
@@ -87,6 +87,7 @@ exports.cli = function (args, exit) {
case '-m':
case '--max':
options.max = args.shift();
+ break;
case '-t':
case '--timeout':
options.global_timeout = args.shift();
Something went wrong with that request. Please try again.