New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in upstream changes from CodeIgniter development branch. #177

Merged
merged 1 commit into from Apr 18, 2013

Conversation

Projects
None yet
2 participants
@nealpoole

nealpoole commented Apr 18, 2013

This resolves issue #163. I added a number of tests to confirm that the output of the function matches the output of the upstream function, but more tests would probably be a good idea in general.

@chriso

This comment has been minimized.

Show comment
Hide comment
@chriso

chriso Apr 18, 2013

Owner

Thanks Neal, this looks great.

Owner

chriso commented Apr 18, 2013

Thanks Neal, this looks great.

chriso added a commit that referenced this pull request Apr 18, 2013

Merge pull request #177 from nealpoole/master
Merge in upstream changes from CodeIgniter development branch.

@chriso chriso merged commit 478f75c into chriso:master Apr 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment