New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some methods to return strict boolean values #286

Merged
merged 1 commit into from Jun 2, 2014

Conversation

Projects
None yet
2 participants
@elegantcoder
Copy link
Contributor

elegantcoder commented May 17, 2014

I found that some methods returns falsy values, and improve it returns false.

@chriso

This comment has been minimized.

Copy link
Owner

chriso commented May 30, 2014

Thanks for the PR but unfortunately some methods return the version, e.g. isIP returns either 4 or 6. This is the expected (albeit poorly documented) behaviour.

@chriso chriso closed this May 30, 2014

@chriso chriso reopened this Jun 2, 2014

@chriso

This comment has been minimized.

Copy link
Owner

chriso commented Jun 2, 2014

Changed my mind 😉

chriso added a commit that referenced this pull request Jun 2, 2014

Merge pull request #286 from elegantcoder/master
Improve some methods to return strict boolean values

@chriso chriso merged commit ffc90fe into chriso:master Jun 2, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@elegantcoder

This comment has been minimized.

Copy link
Contributor

elegantcoder commented Jun 2, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment