Bug in url-validation #70

Merged
merged 1 commit into from Mar 19, 2012

Projects

None yet

2 participants

@RSO

The url validation does not allow special characters in the querystring like " ' ", which it should, according to http://www.ietf.org/rfc/rfc1738.txt:

"Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
reserved characters used for their reserved purposes may be used
unencoded within a URL."

Since there only was one monolithic regex i assumed it was generated, and only added a test for this case, and did not edit the regex.

@RSO RSO Added test to the valid urls which checks for special characters that…
… are allowed unencoded inside a URL

As stated: http://www.ietf.org/rfc/rfc1738.txt:

"Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
   reserved characters used for their reserved purposes may be used
   unencoded within a URL."
6148148
@chriso
Owner

Thanks, I'll modify the regex

@chriso chriso merged commit 2f0b25b into chriso:master Mar 19, 2012
@chriso
Owner

Fixed in f9b72c6

@RSO

Thanks!

@talentedmrjones talentedmrjones pushed a commit to talentedmrjones/node-validator that referenced this pull request Jul 23, 2013
@chriso Allow special chars in url, closes #70 f9b72c6
@shoaibkalsekar shoaibkalsekar pushed a commit that referenced this pull request Dec 17, 2015
@chriso Allow special chars in url, closes #70 b6622f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment