Chris Pan chrisp-fb

  • Facebook
  • Joined on
Chris Pan
FBPaymentObserver - Potential Memory Leak
Chris Pan

This is fixed in 3.23, thanks!

Chris Pan
Chris Pan
Chris Pan
Crash
Chris Pan

Thanks for the report. Unfortunately, we're not able to reproduce the issue. Can you file a report to developers.facebook.com/bugs with code snippe…

Chris Pan

Thanks, we'll look into this.

Chris Pan
Use NSRunLoopCommonModes for NSURLConnections
chrisp-fb commented on pull request facebook/facebook-ios-sdk#696
Chris Pan

Thanks for the feedback. We'll definitely consider this design in the future but making a change now can affect developers who are explicitly manag…

Chris Pan

Sorry, I think I misinterpreted your post as a suggestion to not require browser log-in. If the browser is logged in as a different user, then the …

Chris Pan

I was referring to your suggestion of passing an existing token to the browser flow and not requiring the browser to already have a user logged in.…

Chris Pan
Access token not used when requesting additional permissions
Chris Pan

requesting additional permissions still requires the user to log in if... That's intentional. Having a valid access token is not enough for Faceb…

Chris Pan

This is a legacy code path that was written for older versions of the iOS SDK (i.e., before iOS 6). It looks like initially we were using UIDeviceO…

Chris Pan
FBDialog shouldRotateToOrientation
Chris Pan
Custom connection timeout
Chris Pan

Good idea, we'll add a work item for it but it's unlikely to be high priority - feel free to submit a pull request if you have time. I could easily…

Chris Pan

Hi @gwdp , You're right the errorCodeForError is only intended for FB server side errors (where FBErrorParsedJSONResponseKey is parsed), sorry for…

Chris Pan
[Podspec] Include only public headers from the target's header build phase
chrisp-fb commented on pull request facebook/facebook-ios-sdk#688
Chris Pan

Hey, this should be corrected now in 3.22 - let me know if there's any other issues. Thanks!

Chris Pan

Sorry for the inconvenience, the convenience protocols unfortunately collided with some private Apple selectors. As a workaround, you should be abl…

Chris Pan
App references non-public selectors
Chris Pan
Chris Pan
[Docs] Update docs to clarify wording
2 commits with 1 addition and 1 deletion
chrisp-fb commented on pull request facebook/facebook-ios-sdk#683
Chris Pan

Can you submit a pull request to the dev branch? Thanks.

Chris Pan
[Docs] Clarified header docs for generated files.
chrisp-fb commented on pull request facebook/facebook-ios-sdk#688
Chris Pan

Thanks. Cool fix - ./src was supposed to only have public headers so we'll move the offending files in the next release (or consider the other dire…

Chris Pan

Thanks for the feedback, we'll fix this in the next release. In the meantime as a workaround, you should be able to configure your Podfile with a s…

Chris Pan
image/audio_to_code output to wrong directy in .podspec