fixed ff-console null errors w/ if(!null) wrappers #10

Merged
merged 1 commit into from Jan 8, 2014

Conversation

3 participants
@pdkl95
Contributor

pdkl95 commented Jan 8, 2014

I added a couple if() wrappers around lines that have been showing up as errors in the firefox browser-console. I'm not sure why these were happening in the first place, but the workaround is simple and only touches lines that were failing anyway. Maybe somebody more familiar with the source can check if the error this is hiding is actually relevant.

This is a workaround for this issue mentioned in the forums:
http://forums.chrispederick.com/discussion/386/document-getelementbyid-is-null-7333

@chrispederick

This comment has been minimized.

Show comment Hide comment
@chrispederick

chrispederick Jan 8, 2014

Owner

Thanks for the pull request.

Owner

chrispederick commented Jan 8, 2014

Thanks for the pull request.

chrispederick added a commit that referenced this pull request Jan 8, 2014

Merge pull request #10 from pdkl95/master
fixed ff-console null errors w/ if(!null) wrappers

@chrispederick chrispederick merged commit c0e87ce into chrispederick:master Jan 8, 2014

@Ciwan1859

This comment has been minimized.

Show comment Hide comment
@Ciwan1859

Ciwan1859 Jan 22, 2014

I see this annoying error at work all the time. @pdkl95 how do I get your change? Do I have to re-install web developer toolbar?

Thanks

I see this annoying error at work all the time. @pdkl95 how do I get your change? Do I have to re-install web developer toolbar?

Thanks

@pdkl95

This comment has been minimized.

Show comment Hide comment
@pdkl95

pdkl95 Jan 22, 2014

Contributor

It seems there isn't anything past version 1.2.5 in addons.mozilla.org - I just built a new .xpi from the source when testing that fix.

Here, I'll run the ant build script again, and stuff it into a release...

[Err.. hmm. It seems I cannot upload files to releases on github, as it requires you to drag-and-drop a file. This, of course, requires a graphical file manager.... which I haven't had installed in like a decade. (still using E16 + bash/urxvt for all file management). As a temporary workaround, I will simply stuff the files into a branch.]

You can get the .xpi with my fix here:
https://github.com/pdkl95/web-developer/tree/release_workaround/release_workaround

WARNING: it was build off the master branch a the time of the fix, which my include other changes/bugs/issues. Use with caution!

Contributor

pdkl95 commented Jan 22, 2014

It seems there isn't anything past version 1.2.5 in addons.mozilla.org - I just built a new .xpi from the source when testing that fix.

Here, I'll run the ant build script again, and stuff it into a release...

[Err.. hmm. It seems I cannot upload files to releases on github, as it requires you to drag-and-drop a file. This, of course, requires a graphical file manager.... which I haven't had installed in like a decade. (still using E16 + bash/urxvt for all file management). As a temporary workaround, I will simply stuff the files into a branch.]

You can get the .xpi with my fix here:
https://github.com/pdkl95/web-developer/tree/release_workaround/release_workaround

WARNING: it was build off the master branch a the time of the fix, which my include other changes/bugs/issues. Use with caution!

@Ciwan1859

This comment has been minimized.

Show comment Hide comment
@Ciwan1859

Ciwan1859 Jan 22, 2014

Thanks @pdkl95 :) How long ago did you grab the master branch for fixing? Was it 14 days ago?

Thanks

Thanks @pdkl95 :) How long ago did you grab the master branch for fixing? Was it 14 days ago?

Thanks

@pdkl95

This comment has been minimized.

Show comment Hide comment
@pdkl95

pdkl95 Jan 23, 2014

Contributor

Yah, as noted above. So it's still current with master; I just haven't looked into the other post-1.2.5 changes that much.

Contributor

pdkl95 commented Jan 23, 2014

Yah, as noted above. So it's still current with master; I just haven't looked into the other post-1.2.5 changes that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment