Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting a Uri as value of cell breaks things. #67

Closed
rluiten opened this issue Oct 1, 2019 · 1 comment
Closed

Putting a Uri as value of cell breaks things. #67

rluiten opened this issue Oct 1, 2019 · 1 comment
Labels

Comments

@rluiten
Copy link

rluiten commented Oct 1, 2019

Example i selected a cell pasted in https://github.com/chrispsn/mesh.
Hit Enter and get error in console. VM723:4 Uncaught SyntaxError: Unexpected token :

The code pane shows this

'use strict';
const _CELLS = {
    A1: ({
      v: https://github.com/chrispsn/mesh,
      l: [0,0],
      n: false
    })
}
@chrispsn
Copy link
Owner

chrispsn commented Oct 1, 2019

Thanks, just pushed a short-term fix to how regexes are matched.

Any chance you'd like to tighten it further and submit a pull request? :)

See, eg:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#Advanced_searching_with_flags

@chrispsn chrispsn added the bug label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants