New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to PHP-5.3 #1

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@dstendardi
Contributor

dstendardi commented Dec 12, 2011

Hello !

First of all, congrats for your code & project build quality, it was a pleasure to work on.

I have migrated the library to PSR-0 namespace conventions.
I also added composer.json.

the build is ok using phpunit 3.6.4

Please tell me if you want some changes prior to apply this PR

@christeredvartsen

This comment has been minimized.

Show comment
Hide comment
@christeredvartsen

christeredvartsen Dec 12, 2011

Owner

Hi there,

I have removed the tracker part from the master branch (it will be pushed to a separate branch later). I'll pull in your changes make them work on my local master. I can make a new version of the pear package as well.

Hi there,

I have removed the tracker part from the master branch (it will be pushed to a separate branch later). I'll pull in your changes make them work on my local master. I can make a new version of the pear package as well.

@christeredvartsen

This comment has been minimized.

Show comment
Hide comment
@christeredvartsen

christeredvartsen Dec 15, 2011

Owner

Care to take a look at the namespaces branch? I have pulled in your changes and made some of my own. The encoder and decoder no longer uses static methods, and I have changed the API a bit on the Torrent class.

I will add the tracker part in a day or two.

Care to take a look at the namespaces branch? I have pulled in your changes and made some of my own. The encoder and decoder no longer uses static methods, and I have changed the API a bit on the Torrent class.

I will add the tracker part in a day or two.

@christeredvartsen

This comment has been minimized.

Show comment
Hide comment
@christeredvartsen

christeredvartsen Dec 23, 2011

Owner

There is now a branch called "including-tracker" that has the tracker classes (with namespaces).

There is now a branch called "including-tracker" that has the tracker classes (with namespaces).

@dstendardi

This comment has been minimized.

Show comment
Hide comment
@dstendardi

dstendardi Dec 28, 2011

Contributor

Nothing to say, it's really clean :)

Contributor

dstendardi commented Dec 28, 2011

Nothing to say, it's really clean :)

@christeredvartsen

This comment has been minimized.

Show comment
Hide comment
@christeredvartsen

christeredvartsen Jan 2, 2012

Owner

Merged into the namespaces branch

Owner

christeredvartsen commented Jan 2, 2012

Merged into the namespaces branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment