New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the terraform.py hardcode in this project and rely on the GIT … #1

Merged
merged 7 commits into from Mar 11, 2016

Conversation

Projects
None yet
2 participants
@charly37
Contributor

charly37 commented Mar 5, 2016

I verified that there were no difference between the version copy in this project and the github version. The version in this project is the same as f5ccbc211ddadaac10f444afe97b508da55248e8 commit on the github project.

I do that for 2 reasons :
-The less code we have the easier it is for user to read it and trust our scripts (I was worried about what this terraform.py was doing before I understand it was coming from another github repo)
-We will benefit from the change made on the remote repo. This is particularly true in my case since I was trying to deploy on GCE and there is a bug in the terraform.py included in this repo but it is fix on the GITHUB terraform.py repo

This is a pre-commit to then add GCE support in this repo.

Remove the terraform.py hardcode in this project and rely on the GIT …
…version.

I verified that there were no difference between the version copy in this project and the github version. The version in this project is the same as f5ccbc211ddadaac10f444afe97b508da55248e8 commit on the github project.
I do that for 2 reasons :
-The less code we have the easier it is for user to read it and trust our scripts (I was worried about what this terraform.py was doing before I understand it was coming from another github repo)
-We will benefit from the change made on the remote repo. This is particularly true in my case since I was trying to deploy on GCE and there is a bug in the terraform.py included in this repo but it is fix on the GITHUB terraform.py repo
This is a pre-commit to then add GCE support in this repo.
@charly37

This comment has been minimized.

Show comment
Hide comment
@charly37

charly37 Mar 5, 2016

Contributor

Here is the check to ensure that the terraform.py file included in this repo do not have more code than the github

[tmpuser@tmpsrv ~]$ cd TestCharlesToDel

[tmpuser@tmpsrv TestCharlesToDel]$ git clone https://github.com/christian-posta/openshift-terraform-ansible.git
Cloning into 'openshift-terraform-ansible'...
remote: Counting objects: 42, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 42 (delta 17), reused 42 (delta 17), pack-reused 0
Unpacking objects: 100% (42/42), done.

[tmpuser@tmpsrv TestCharlesToDel]$ git clone https://github.com/CiscoCloud/terraform.py.git
Cloning into 'terraform.py'...
remote: Counting objects: 179, done.
remote: Total 179 (delta 0), reused 0 (delta 0), pack-reused 179
Receiving objects: 100% (179/179), 55.69 KiB | 0 bytes/s, done.
Resolving deltas: 100% (97/97), done.
[tmpuser@tmpsrv TestCharlesToDel]$ cd terraform.py/
[tmpuser@tmpsrv terraform.py]$ git reset --hard f5ccbc211ddadaac10f444afe97b508da55248e8
HEAD is now at f5ccbc2 added some color about using sshUser tag for instances"

[tmpuser@tmpsrv terraform.py]$ diff terraform.py ../openshift-terraform-ansible/terraform.py

Contributor

charly37 commented Mar 5, 2016

Here is the check to ensure that the terraform.py file included in this repo do not have more code than the github

[tmpuser@tmpsrv ~]$ cd TestCharlesToDel

[tmpuser@tmpsrv TestCharlesToDel]$ git clone https://github.com/christian-posta/openshift-terraform-ansible.git
Cloning into 'openshift-terraform-ansible'...
remote: Counting objects: 42, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 42 (delta 17), reused 42 (delta 17), pack-reused 0
Unpacking objects: 100% (42/42), done.

[tmpuser@tmpsrv TestCharlesToDel]$ git clone https://github.com/CiscoCloud/terraform.py.git
Cloning into 'terraform.py'...
remote: Counting objects: 179, done.
remote: Total 179 (delta 0), reused 0 (delta 0), pack-reused 179
Receiving objects: 100% (179/179), 55.69 KiB | 0 bytes/s, done.
Resolving deltas: 100% (97/97), done.
[tmpuser@tmpsrv TestCharlesToDel]$ cd terraform.py/
[tmpuser@tmpsrv terraform.py]$ git reset --hard f5ccbc211ddadaac10f444afe97b508da55248e8
HEAD is now at f5ccbc2 added some color about using sshUser tag for instances"

[tmpuser@tmpsrv terraform.py]$ diff terraform.py ../openshift-terraform-ansible/terraform.py

christian-posta added a commit that referenced this pull request Mar 11, 2016

Merge pull request #1 from charly37/master
Remove the terraform.py hardcode in this project and rely on the GIT …

@christian-posta christian-posta merged commit 048545f into christian-posta:master Mar 11, 2016

@christian-posta

This comment has been minimized.

Show comment
Hide comment
@christian-posta

christian-posta Mar 11, 2016

Owner

Awesome, thanks!

Owner

christian-posta commented Mar 11, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment