Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGitCommit.raw_log only drop last msg line if blank #42
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hi @scottnonnenberg, thanks a lot for fixing this! Do you think we could also add a test that ensures one-line commit messages aren't being dropped in the future? |
jankeromnes
reviewed
Apr 16, 2015
lib/git/internal/git_commit.js
Outdated
| length -= 1; | ||
| } | ||
| for(var i = 0; i < length; i++) { | ||
| output = output + ' ' + lines[i] + '\n'; |
This comment has been minimized.
This comment has been minimized.
jankeromnes
reviewed
Apr 16, 2015
lib/git/internal/git_commit.js
Outdated
| // drop last line if it's blank | ||
| if (length > 0 && lines[length - 1].length === 0) { | ||
| length -= 1; |
This comment has been minimized.
This comment has been minimized.
scottnonnenberg
added some commits
Apr 16, 2015
This comment has been minimized.
This comment has been minimized.
|
Unit tests added. Seems that the couple full repos under /test all have the expected trailing newline, so I couldn't use any existing fixture data. |
This comment has been minimized.
This comment has been minimized.
|
Awesome, thanks! |
jankeromnes
merged commit c88e44a
into
christkv:master
Apr 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
scottnonnenberg commentedApr 15, 2015
Fixes the message-dropping behavior I saw, potentially the same thing as #38.