From 83ffb2408df02ee45550b38f86b7ebfb4380780a Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Thu, 11 Feb 2021 16:17:17 -0300 Subject: [PATCH 1/7] Trying new configurations for Travis --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 59cb0290df..43543cd501 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,6 +39,7 @@ script: -DLAPACKE:BOOL=ON -DBUILD_TESTING=ON -DLAPACKE_WITH_TMG:BOOL=ON + -DCMAKE_Fortran_FLAGS:STRING="-frecursive -fimplicit-none" ${SRC_DIR} - ctest -D ExperimentalStart - ctest -D ExperimentalConfigure From a8d3630c8aa027d6e7a44e1ffd81e7f171b48f61 Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Thu, 11 Feb 2021 17:19:06 -0300 Subject: [PATCH 2/7] Trying new configurations for Travis --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 43543cd501..815a31a640 100644 --- a/.travis.yml +++ b/.travis.yml @@ -41,10 +41,15 @@ script: -DLAPACKE_WITH_TMG:BOOL=ON -DCMAKE_Fortran_FLAGS:STRING="-frecursive -fimplicit-none" ${SRC_DIR} + - ulimit -s 16384 - ctest -D ExperimentalStart + - ulimit -s 16384 - ctest -D ExperimentalConfigure + - ulimit -s 16384 - ctest -D ExperimentalBuild -j2 + - ulimit -s 16384 - ctest -D ExperimentalTest --schedule-random -j2 --output-on-failure --timeout 100 + - ulimit -s 16384 - ctest -D ExperimentalSubmit - make install -j2 - if [[ "$CMAKE_BUILD_TYPE" == "Coverage" ]]; From bc371b5af3ae5f986c4af6a0f3fb1669d008f1a9 Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Thu, 11 Feb 2021 20:24:55 -0300 Subject: [PATCH 3/7] Fix bug in CMakeLists.txt that is causing trouble to AppVeyor --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 682c3c476e..345bc0efaf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -180,7 +180,7 @@ CheckLAPACKCompilerFlags() # Check second function include(CheckTimeFunction) -set(TIME_FUNC NONE ${TIME_FUNC}) +set(NONE ${TIME_FUNC}) CHECK_TIME_FUNCTION(NONE TIME_FUNC) CHECK_TIME_FUNCTION(INT_CPU_TIME TIME_FUNC) CHECK_TIME_FUNCTION(EXT_ETIME TIME_FUNC) From 6986b38ce28864b84ac6494a6ef4b261cfac387c Mon Sep 17 00:00:00 2001 From: "Weslley S. Pereira" Date: Fri, 12 Feb 2021 11:44:03 -0300 Subject: [PATCH 4/7] Avoid using a specific value for ulimit --- .travis.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 815a31a640..5c88ebc0b9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -41,15 +41,11 @@ script: -DLAPACKE_WITH_TMG:BOOL=ON -DCMAKE_Fortran_FLAGS:STRING="-frecursive -fimplicit-none" ${SRC_DIR} - - ulimit -s 16384 + - ulimit -s unlimited - ctest -D ExperimentalStart - - ulimit -s 16384 - ctest -D ExperimentalConfigure - - ulimit -s 16384 - ctest -D ExperimentalBuild -j2 - - ulimit -s 16384 - ctest -D ExperimentalTest --schedule-random -j2 --output-on-failure --timeout 100 - - ulimit -s 16384 - ctest -D ExperimentalSubmit - make install -j2 - if [[ "$CMAKE_BUILD_TYPE" == "Coverage" ]]; From e8eb92048580c1c068bba61c46cfcd2f930fc72a Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Fri, 12 Feb 2021 12:45:13 -0300 Subject: [PATCH 5/7] Adds fimplicit-none to default make.inc for gfortran --- INSTALL/make.inc.gfortran | 4 ++-- INSTALL/make.inc.gfortran-quad | 4 ++-- make.inc.example | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/INSTALL/make.inc.gfortran b/INSTALL/make.inc.gfortran index 1046327473..89499d85f9 100644 --- a/INSTALL/make.inc.gfortran +++ b/INSTALL/make.inc.gfortran @@ -20,9 +20,9 @@ CFLAGS = -O3 # should not compile LAPACK with flags such as -ffpe-trap=overflow. # FC = gfortran -FFLAGS = -O2 -frecursive +FFLAGS = -O2 -frecursive -fimplicit-none FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive +FFLAGS_NOOPT = -O0 -frecursive -fimplicit-none # Define LDFLAGS to the desired linker options for your machine. # diff --git a/INSTALL/make.inc.gfortran-quad b/INSTALL/make.inc.gfortran-quad index 2bcbc6b3a4..e3f3e7750f 100644 --- a/INSTALL/make.inc.gfortran-quad +++ b/INSTALL/make.inc.gfortran-quad @@ -27,9 +27,9 @@ CFLAGS = -O3 # type. # FC = gfortran -FFLAGS = -O2 -frecursive -freal-4-real-16 -freal-8-real-16 +FFLAGS = -O2 -frecursive -freal-4-real-16 -freal-8-real-16 -fimplicit-none FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive -freal-4-real-16 -freal-8-real-16 +FFLAGS_NOOPT = -O0 -frecursive -freal-4-real-16 -freal-8-real-16 -fimplicit-none # Define LDFLAGS to the desired linker options for your machine. # diff --git a/make.inc.example b/make.inc.example index 57fd51ebe1..9ec914b3c9 100644 --- a/make.inc.example +++ b/make.inc.example @@ -20,9 +20,9 @@ CFLAGS = -O3 # should not compile LAPACK with flags such as -ffpe-trap=overflow. # FC = gfortran -FFLAGS = -O2 -frecursive +FFLAGS = -O2 -frecursive -fimplicit-none FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive +FFLAGS_NOOPT = -O0 -frecursive -fimplicit-none # Define LDFLAGS to the desired linker options for your machine. # From 83d993be1ef14264595d6df81bb9b9ebc2a11bf5 Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Fri, 12 Feb 2021 12:45:45 -0300 Subject: [PATCH 6/7] Travis config file without frecursive --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5c88ebc0b9..58bcc54903 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,9 +39,8 @@ script: -DLAPACKE:BOOL=ON -DBUILD_TESTING=ON -DLAPACKE_WITH_TMG:BOOL=ON - -DCMAKE_Fortran_FLAGS:STRING="-frecursive -fimplicit-none" + -DCMAKE_Fortran_FLAGS:STRING="-fimplicit-none" ${SRC_DIR} - - ulimit -s unlimited - ctest -D ExperimentalStart - ctest -D ExperimentalConfigure - ctest -D ExperimentalBuild -j2 From ea85b47fbd5c3e6c512dd34b5cf1a18ebc3689ce Mon Sep 17 00:00:00 2001 From: "weslley.spereira" Date: Fri, 12 Feb 2021 13:51:32 -0300 Subject: [PATCH 7/7] Revert "Adds fimplicit-none to default make.inc for gfortran" This reverts commit e8eb92048580c1c068bba61c46cfcd2f930fc72a based on @thijssteel's comment at https://github.com/Reference-LAPACK/lapack/pull/486#issuecomment-778304791 --- INSTALL/make.inc.gfortran | 4 ++-- INSTALL/make.inc.gfortran-quad | 4 ++-- make.inc.example | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/INSTALL/make.inc.gfortran b/INSTALL/make.inc.gfortran index 89499d85f9..1046327473 100644 --- a/INSTALL/make.inc.gfortran +++ b/INSTALL/make.inc.gfortran @@ -20,9 +20,9 @@ CFLAGS = -O3 # should not compile LAPACK with flags such as -ffpe-trap=overflow. # FC = gfortran -FFLAGS = -O2 -frecursive -fimplicit-none +FFLAGS = -O2 -frecursive FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive -fimplicit-none +FFLAGS_NOOPT = -O0 -frecursive # Define LDFLAGS to the desired linker options for your machine. # diff --git a/INSTALL/make.inc.gfortran-quad b/INSTALL/make.inc.gfortran-quad index e3f3e7750f..2bcbc6b3a4 100644 --- a/INSTALL/make.inc.gfortran-quad +++ b/INSTALL/make.inc.gfortran-quad @@ -27,9 +27,9 @@ CFLAGS = -O3 # type. # FC = gfortran -FFLAGS = -O2 -frecursive -freal-4-real-16 -freal-8-real-16 -fimplicit-none +FFLAGS = -O2 -frecursive -freal-4-real-16 -freal-8-real-16 FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive -freal-4-real-16 -freal-8-real-16 -fimplicit-none +FFLAGS_NOOPT = -O0 -frecursive -freal-4-real-16 -freal-8-real-16 # Define LDFLAGS to the desired linker options for your machine. # diff --git a/make.inc.example b/make.inc.example index 9ec914b3c9..57fd51ebe1 100644 --- a/make.inc.example +++ b/make.inc.example @@ -20,9 +20,9 @@ CFLAGS = -O3 # should not compile LAPACK with flags such as -ffpe-trap=overflow. # FC = gfortran -FFLAGS = -O2 -frecursive -fimplicit-none +FFLAGS = -O2 -frecursive FFLAGS_DRV = $(FFLAGS) -FFLAGS_NOOPT = -O0 -frecursive -fimplicit-none +FFLAGS_NOOPT = -O0 -frecursive # Define LDFLAGS to the desired linker options for your machine. #