Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converts windows path separators #1

Merged
merged 2 commits into from
Feb 15, 2013

Conversation

hyarion
Copy link
Contributor

@hyarion hyarion commented Feb 12, 2013

converts windows path separators ('') used in #include directive to unix compatible path separators ('/')

@christopherpow
Copy link
Owner

Thanks hyarion! I knew there'd be cross-platform problems because I
haven't yet had a chance to try compiling it or my MFC HLE on anything but
Windows. I know there's at least one or two APIs that FamiTracker's still
using still that are Windows-only [GetSysColor, ...] because I haven't put
thought to their Qt replacement yet.

I'll pull your merge tonight...can't do it now I'm at work.

Thanks for your help!

On Tue, Feb 12, 2013 at 5:58 AM, Benjamin Eriksson <notifications@github.com

wrote:

converts windows path separators ('') used in #include directive to unix

compatible path separators ('/')

You can merge this Pull Request by running

git pull https://github.com/hyarion/nesicide xplatform

Or view, comment on, or merge it at:

#1
Commit Summary

  • converts windows path separators

File Changes

Patch Links:

@hyarion
Copy link
Contributor Author

hyarion commented Feb 12, 2013

Your welcome!
As you can see I added a new commit which re-implements some windows specific datatypes, I should work, but since (at least) one file is still missing ( FamiTrackerView.h ) I couldn't compile the rest of the project.

@christopherpow
Copy link
Owner

That file should be there now...? git doesn't show me as not having added
it. Let me know.

I am working on integrating the SoundGen thread so I can have this thing
animate and...eventually...play! =]

Note: it's nowhere near done, but major portions of functionality are
working. I haven't integrated any of the config dialogs or the instrument
editors yet. But the frame editor and pattern editor are working mostly
nicely together.

I'm excited to get this working on OSX! I also am hoping to refresh my
Ubuntu VM and try it there...but I am stuck in "dev" mode for the moment on
Windows! =]

Hope all is well with you!

On Tue, Feb 12, 2013 at 8:10 AM, Benjamin Eriksson <notifications@github.com

wrote:

Your welcome!
As you can see I added a new commit which re-implements some windows
specific datatypes, I should work, but since (at least) one file is still
missing ( FamiTrackerView.h ) I couldn't compile the rest of the project.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13433863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants