Bugfix: allow backing up of read-only mount /data #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clarification: symlinks directly inside |
|
Sorry, there is a bug currently. Please allow me to fix this and I will let you know. |
Myridium
force-pushed
the
ro_patch
branch
7 times, most recently
from
059564d
to
8ebc8a7
Compare
This commit allows the user to backup mounts at /data which are mounted as read-only. There is a slight break to previous behaviour which may affect some users: symlinks inside /data which point to absolute paths *used* to be followed, and their contents included in the backup. This is no longer the case.
|
Okay, I've tested it a bit with my data and it seems to be working okay now. |
|
Thanks! Merged and released as v1.6.0 |
|
Thanks for making the docker container, and for merging. Looks like I can switch over to Duplicacy now :) |
|
@christophetd hi, the pipeline seems to have failed and this hasn't been uploaded to Docker Hub. It looks like the pipeline is just upset that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the user to backup mounts at /data which are mounted
as read-only. There is a slight break to previous behaviour which may
affect some users: symlinks inside /data which point to absolute paths
used to be followed, and their contents included in the backup. This
is no longer the case.