Skip to content

Subclass StandardError instead of Exception. #8

Merged
merged 1 commit into from Mar 18, 2012

2 participants

@solson
solson commented Mar 16, 2012

RLTK should use subclasses of StandardError instead of Exception. Exception is generally reserved for things which are fatal to Ruby itself and most application errors are under StandardError. Plus, the standard rescue without any argument catches any subclasses of StandardError, but not of Exception.

@chriswailes chriswailes merged commit bccab55 into chriswailes:master Mar 18, 2012
@chriswailes
Owner

Thanks for the information. Given this new knowledge I would say your patch is about 90% correct. The InternalParserError and ParserConstructionError classes should really be subclasses of Exception, and as such renamed to indicate this. I've merged your repo and made the necessary changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.