Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen JS Client API #1543

Open
tazarov opened this issue Dec 18, 2023 · 2 comments
Open

Regen JS Client API #1543

tazarov opened this issue Dec 18, 2023 · 2 comments

Comments

@tazarov
Copy link
Contributor

tazarov commented Dec 18, 2023

The JS client API seems to be a bit out of date with recent changes to FastAPI. It needs to be regenerated, and some of the JS tests refreshed.

@jeffchuber
Copy link
Contributor

jeffchuber commented Dec 18, 2023 via email

@tazarov
Copy link
Contributor Author

tazarov commented Dec 18, 2023

I did a fix in #1494 where I made errors returned by the API consistent:

Before:

//Chroma Errors
{
"error":"<type of error>",
"message":"<exception message>"
}
//Other errors
{
"error":"<type of error> + <error message>"
}

After:

{
"error":"<type of error>",
"message":"<exception message>"
}

I've noticed that the JS API did not have the message parameter (basically, a test was failing as the expected message was in error instead of the message attribute of the error response). I tried regenerating the client but got some errors, which might be related to the API changes.

This issue is just a placeholder for me to look at later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants