Browse files

Really enabled PDF support, Mohammed Arafat Kamaal.

  • Loading branch information...
1 parent d04de6c commit f58eed6f9b4e7cc8ba1fb8b47930198fd28d238e @chromatic committed Sep 17, 2010
Showing with 11 additions and 7 deletions.
  1. +1 −0 .gitignore
  2. +3 −0 CREDITS
  3. +7 −0 README
  4. +0 −7 build/tools/
@@ -1,3 +1,4 @@
@@ -164,3 +164,6 @@ E:
N: Gabrielle Roth
+N: Mohammed Arafat Kamaal
@@ -83,6 +83,13 @@ To build an ePub eBook from the woven chapters:
This will produce an ePub eBook in the build/epub/ directory.
+To build PDFs from the chapters:
+ $ perl build/tools/
+This will build PDFs in the build/pdf directory. You must have App::pod2pdf
+installed from the CPAN.
Contributing to Modern Perl
@@ -3,7 +3,6 @@
use strict;
use warnings;
-use File::Path;
use File::Spec::Functions qw( catfile catdir splitpath );
# getting chapter list
@@ -15,12 +14,6 @@
my $outpath = catdir( qw( build pdf ) );
-# Make directory for copying PDFs

melo Sep 17, 2010

Why was this code removed?

My first run failed because the build/pdf/ dir was not there, and this code would have made it work.

I would revert this part...


chromatic Sep 17, 2010


I checked in a .gitignore file under build/pdf/ so the directory should always be there. At least, I tried to check in a .gitignore file.


melo Sep 18, 2010

Wont work.

Git does not preserve empty directories.

If you want to keep the directory, you need a file inside.

Or revert the make_path stuff.


chromatic Sep 23, 2010


I've just confirmed that the build/epub/ directory is in the tree on GH as of b205634, so I think it'll work. If you can reproduce with a fresh checkout, I'll replace the directory code.


melo Sep 25, 2010


I can reproduce with a fresh checkout. See screencast here:

I clone your repo, build chapters and when I try to build the pdf, I get the errors because the pdf/ directory is not present.

-unless (-d $outpath)
- File::Path::make_path($outpath) or die "Can't build path: $!\n";
for my $chapter ( @chapters ){
my @filename = split( /\./ , $chapter );
print "Converting $chapter to pdf\n";

0 comments on commit f58eed6

Please sign in to comment.