Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation Português - conclusion #196

Merged
merged 2 commits into from Nov 9, 2019
Merged

Fix translation Português - conclusion #196

merged 2 commits into from Nov 9, 2019

Conversation

GilsonSantosUX
Copy link
Contributor

Fix article in portugues translation "conclusion"

Fix article in portugues translation "conclusion"
Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left in a couple of comments.

Feel free to go over them and make the changes or comment about the proposed changes so that we can reach a understanding so that the document move along.


## Saber mais

Pretende saber mais? Aqui ficam alguns recursos que irão ajudar.
Pretende saber mais? Aqui ficam algumas dicas que irão ajudar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing should remain as it is, they are articles and should be treated as a resource not tips

content/intro-to-storybook/vue/pt/conclusion.md Outdated Show resolved Hide resolved

- [**Manual de testes visuais**](https://blog.hichroma.com/the-delightful-storybook-workflow-b322b76fd07)
enumera as boas práticas de fluxo de trabalho, usadas por equipas que operam a alta velocidade, tal como por exemplo a SquareSpace, a Major League Soccer, a Discovery Network e Apollo GraphQL.
enumera as boas práticas de fluxo de trabalho, usadas por equipes que operam a alta velocidade, tal como por exemplo a SquareSpace, a Major League Soccer, a Discovery Network e Apollo GraphQL.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is one of those....., i know that the wording in brazilian portuguese is "equipes", if you don't mind leaving it as is for the time being. The choice of words needs to be better researched so that the translation doesn't break it's meaning and can appeal to both readers.

content/intro-to-storybook/vue/pt/conclusion.md Outdated Show resolved Hide resolved
@@ -3,31 +3,32 @@ title: 'Conclusão'
description: 'Fusão de todo o conhecimento adquirido e aprendizagem de técnicas extra de Storybook'
---

Parabéns! Acabaste de criar o teu primeiro interface de utilizador com Storybook. Durante esta jornada aprendeste como construir, compor, testar e implementar componentes de interface de utilizador.
Se estiveste a seguir o tutorial, o repositório e o Storybook implementado irá ser idêntico a este:
Parabéns! Você criou sua primeira interface do usuário no Storybook. Ao longo do caminho, você aprendeu a criar, compor, testar e implantar componentes da interface do usuário. Se você seguiu o tutorial, seu repositório e o Storybook implantado devem ficar assim:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a better wording for this could be:
"Parabéns! Acabou de criar o primeiro interface de utilizador com o Storybook. Ao longo do caminho, aprendeu a criar, compor, testar e implementar componentes de interface de utilizador. Se seguiu o tutorial o repositório e o Storybook deverão ficar assim"

Reasoning behind this:

  • Avoid usage of "você" to maintain a professional tone to the document without breaking verb tenses and grammar involved.
  • i know about the usage of "utilizador", in brazilian it's customary to use "usuário". "Utilizador" is a valid word that is recognized by both readers and once again if the end goal of the documentation is to reach the maximum number of people it would be best to use some words/terms that are more "universal" to avoid "tipping the scale to one plate"(pardon the bad pun).
  • Removed both "implementado" and "implantado", to avoid any language specialization, when the reader reaches this point it knows that it has a fully functional code repository in GitHub and also its own Storybook deployed in netlify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show, value for the collaboration.

content/intro-to-storybook/vue/pt/conclusion.md Outdated Show resolved Hide resolved
Adjusted grammar
Thanks for the explanations given by our friend @jonniebigodes.
Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing to address and this should be good to merge


## Saber mais

Pretende saber mais? Aqui ficam algumas dicas que irão ajudar.
Pretende saber mais? Aqui ficam algumas recursos que irão ajudar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, change the genre to masculin to avoid introducing a grammar error. It should be "alguns recursos", not "algumas recursos".

@jonniebigodes
Copy link
Collaborator

When you can, merge this and i'll update the other relative documents and fix the typo.

@jonniebigodes
Copy link
Collaborator

@domyen or @tmeasday is it ok if we merge this. I'm going to create a pull request that addresses the typo and update the remaining translations aswell so that they all align with this.

@domyen
Copy link
Member

domyen commented Nov 9, 2019

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants