Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating addons section #91

Merged
merged 11 commits into from Oct 5, 2019

Conversation

@ndelangen
Copy link
Member

commented May 16, 2019

This add a section to the guide on how to write addons

@ndelangen ndelangen requested a review from tmeasday May 16, 2019
@ndelangen ndelangen self-assigned this May 16, 2019
Copy link
Member

left a comment

So cool! I reckon we probably want to include some images of what things look like along the way.

@domyen probably has more to say

content/react/en/creating-addons.md Outdated Show resolved Hide resolved
@domyen

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@ndelangen @zol is this still active?

@zol

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

@domyen to the best of my knowledge, this was/is blocked on the 5.2 release, @ndelangen is that correct?

@ndelangen

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

correct, we need 5.2 to be released, which has the new hooks apis in it.

Copy link
Member

left a comment

I'm good to merge this after my outstanding comments are addressed!

content/react/en/creating-addons.md Outdated Show resolved Hide resolved
content/react/en/creating-addons.md Outdated Show resolved Hide resolved
content/react/en/creating-addons.md Outdated Show resolved Hide resolved
content/react/en/creating-addons.md Outdated Show resolved Hide resolved
ndelangen added 3 commits Sep 23, 2019
IMPROVE mention current config path
ADD section about addons.js
@ndelangen

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

@zol WDYT, mergeable?

@zol

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@ndelangen It's almost good to go from my end, just need a better screenshot as per my remaining outstanding comment

@ndelangen

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Screenshot 2019-10-04 at 14 15 18

@zol WDYT?

@ndelangen

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Bit more stylised:
Screenshot 2019-10-04 at 14 16 58

ndelangen added 4 commits Oct 4, 2019
# Conflicts:
#	content/intro-to-storybook/react/en/addons.md
#	content/intro-to-storybook/react/pt/addons.md
#	content/react/en/addons.md
#	content/react/en/using-addons.md
#	content/react/pt/addons.md
#	content/react/pt/using-addons.md
#	gatsby-config.js
@ndelangen

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Screenshot 2019-10-04 at 14 56 02

@zol WDYT?

@zol

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Looks great @ndelangen . I'm ready to have this merged and shipped!

@tmeasday

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

@domyen merge when ready!

@ndelangen ndelangen merged commit 095f02c into master Oct 5, 2019
3 checks passed
3 checks passed
ci/chromatic 47 stories unchanged.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ndelangen ndelangen deleted the creating-addons-section branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.