From 16a484f0be1881b9c8f54b34fedf6b1527011d46 Mon Sep 17 00:00:00 2001 From: Song Fangzhen Date: Sat, 8 May 2021 23:54:46 +0000 Subject: [PATCH] CodeHealth: Remove use of DictionaryValue::empty in /ash/display This change removes the use of DictionaryValue::empty() and replaces with Value::DictEmpty() This CL was uploaded by git cl split. R=afakhry@chromium.org Bug: 1187020 Change-Id: Ic557a205607118455834c5b638a55a58550764bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2879647 Commit-Queue: Ahmed Fakhry Auto-Submit: Fangzhen Song Reviewed-by: Ahmed Fakhry Cr-Commit-Position: refs/heads/master@{#880748} --- ash/display/display_prefs.cc | 2 +- ash/display/display_prefs_unittest.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ash/display/display_prefs.cc b/ash/display/display_prefs.cc index cdcdc24ff9447d..e25296eb82b738 100644 --- a/ash/display/display_prefs.cc +++ b/ash/display/display_prefs.cc @@ -675,7 +675,7 @@ void StoreDisplayTouchAssociations(PrefService* pref_service) { base::NumberToString(association_info.first), association_info_value->Clone()); } - if (association_info_map_value.empty()) + if (association_info_map_value.DictEmpty()) continue; // Move the already serialized entry of AssociationInfoMap from diff --git a/ash/display/display_prefs_unittest.cc b/ash/display/display_prefs_unittest.cc index 1c1f2071f0c7c8..a8476f48ee4287 100644 --- a/ash/display/display_prefs_unittest.cc +++ b/ash/display/display_prefs_unittest.cc @@ -1564,7 +1564,7 @@ TEST_F(DisplayPrefsTest, DisplayMixedMirrorMode) { // Check the preferences. pref_data = local_state()->GetDictionary(prefs::kDisplayMixedMirrorModeParams); - EXPECT_TRUE(pref_data->empty()); + EXPECT_TRUE(pref_data->DictEmpty()); } } // namespace ash