From 29cc5cc2168986b952e1f703c85c1a5f3ffada8c Mon Sep 17 00:00:00 2001 From: Neil Coronado Date: Thu, 1 Jun 2023 21:57:02 +0000 Subject: [PATCH] [TabStripRedesign] Fix new tab button anchoring on tab close Fix new tab button anchoring on tab close. -Only affects TSR enabled & anchoring disabled. Before: https://drive.google.com/file/d/1MjVqrNRUKabfGDsiN5HTsm5Wg9b636-k/view?usp=drive_link After: https://drive.google.com/file/d/1uyQOzLifCQgEpApocat3Qxq2ZQzNBb8b/view?usp=drive_link (cherry picked from commit 0e045fe5530348d150d21cf3590ed17d46b5878e) Bug: 1447109 Change-Id: I2cb5ac164dec1ac87c1c0b8e2b4554319f0ef991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573732 Reviewed-by: Theresa Sullivan Commit-Queue: Neil Coronado Cr-Original-Commit-Position: refs/heads/main@{#1150940} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582707 Reviewed-by: Zhe Li Commit-Queue: Zhe Li Auto-Submit: Neil Coronado Cr-Commit-Position: refs/branch-heads/5790@{#233} Cr-Branched-From: 1d71a337b1f6e707a13ae074dca1e2c34905eb9f-refs/heads/main@{#1148114} --- .../browser/compositor/overlays/strip/StripLayoutHelper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java index 64bf0b926df8d..d1af27adf35cd 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java @@ -1267,7 +1267,7 @@ private void resizeStripOnTabClose(int tabId, Tab nextTab) { } // 4. Add new tab button offset animation. - if (!ChromeFeatureList.sTabStripRedesign.isEnabled()) { + if (isNewTabButtonAnchorDisabled()) { CompositorAnimator newTabButtonOffsetAnimator = updateNewTabButtonState(true); if (newTabButtonOffsetAnimator != null) { tabStripAnimators.add(newTabButtonOffsetAnimator);