From 38084c41f7795df9eac0a1556a54dbea5d59467c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacobo=20Aragunde=20P=C3=A9rez?= Date: Wed, 8 Dec 2021 04:31:23 +0000 Subject: [PATCH] Include hidden objects in accessible tree. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Include display:none, visibility:hidden and aria-hidden elements in the accessible tree. We plan to use them to streamline the calculation of accessible names, so it does not require additional DOM or layout tree traversals. We previously attempted to include only those hidden nodes which were required for accname calculation, but there were complications to keep the tree up-to-date. This is much easier to maintain and it doesn't seem to have a noticeable performance impact. A sizeable number of DumpAccessibilityTreeTest expectations were updated to include the newly included hidden nodes. Original author was aleventhal@chromium.org in: http://crrev.com/c/3197971 Bug: 1255036 Change-Id: I899781b654dd2b1dd97473b92e26d95fa54376bc Cq-Include-Trybots: luci.chromium.try:win7-blink-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217730 Reviewed-by: Jonathan Ross Reviewed-by: Aaron Leventhal Reviewed-by: Nektarios Paisios Commit-Queue: Jacobo Aragunde Pérez Cr-Commit-Position: refs/heads/main@{#949376} --- .../aria/aria-empty-string-expected-blink.txt | 1 + .../aria/aria-hidden-expected-blink.txt | 4 ++ ...descendant-display-none-expected-blink.txt | 8 ++- ...ndant-visibility-hidden-expected-blink.txt | 2 + .../aria/aria-owns-crash-expected-blink.txt | 4 +- .../aria/aria-undefined-expected-blink.txt | 1 + .../aria-undefined-literal-expected-blink.txt | 1 + .../hidden-described-by-expected-blink.txt | 3 +- .../aria/hidden-expected-blink.txt | 2 + .../hidden-labelled-by-expected-blink.txt | 3 +- .../table-column-hidden-expected-blink.txt | 3 ++ .../css/alt-text-expected-blink.txt | 1 + ...bility-auto-aria-hidden-expected-blink.txt | 2 + ...ty-hidden-check-failure-expected-blink.txt | 2 + ...nt-visibility-to-hidden-expected-blink.txt | 5 ++ .../css/display-none-expected-blink.txt | 4 ++ ...nt-css-alternative-text-expected-blink.txt | 1 + .../css/visibility-expected-blink.txt | 2 + .../visibility-to-hidden-expected-blink.txt | 1 + .../display-locking/all-expected-blink.txt | 2 + .../non-activatable-expected-blink.txt | 8 +++ ...d-dialog-described-by-expected-uia-win.txt | 3 +- ...-dialog-described-by-expected-uia-win7.txt | 3 +- .../add-dialog-described-by-expected-win.txt | 3 +- .../event/add-dialog-expected-uia-win.txt | 3 +- .../event/add-dialog-expected-uia-win7.txt | 3 +- .../event/add-dialog-expected-win.txt | 3 +- .../add-dialog-no-info-expected-uia-win.txt | 3 +- .../add-dialog-no-info-expected-uia-win7.txt | 3 +- .../event/add-dialog-no-info-expected-win.txt | 3 +- ...t-visibility-hidden-expected-auralinux.txt | 2 - .../html/accordion-expected-blink.txt | 4 ++ .../html/custom-element-expected-blink.txt | 10 +++- .../custom-element-hidden-expected-blink.txt | 5 +- ...t-with-aria-owns-inside-expected-blink.txt | 4 +- .../html/details-expected-blink.txt | 1 + ...tent-after-hidden-input-expected-blink.txt | 3 +- ...-invalid-children-added-expected-blink.txt | 1 + .../html/input-list-expected-blink.txt | 1 - ...gestions-source-element-expected-blink.txt | 1 - .../html/landmark-expected-blink.txt | 6 +++ .../html/meter-expected-blink.txt | 1 + .../modal-dialog-closed-expected-blink.txt | 2 + .../modal-dialog-stack-expected-blink.txt | 2 + .../html/modal-dialog-stack.html | 4 +- .../html/open-modal-expected-blink.txt | 4 +- .../html/ruby-expected-blink.txt | 4 ++ .../html/select-in-canvas-expected-blink.txt | 2 + .../html/summary-expected-blink.txt | 2 + .../html/svg-desc-in-group-expected-blink.txt | 2 + ...lements-not-mapped-expected-blink-cros.txt | 40 +++++++++++++- ...svg-elements-not-mapped-expected-blink.txt | 38 +++++++++++++ .../accessibility/html/svg-expected-blink.txt | 2 + .../svg-symbol-with-role-expected-blink.txt | 6 +++ ...alternative-computation-expected-blink.txt | 39 ++++++++++++++ .../svg-title-in-group-expected-blink.txt | 1 + ...svg-with-clickable-rect-expected-blink.txt | 1 + .../table-column-remove-expected-blink.txt | 2 + .../accessibility/html/wbr-expected-blink.txt | 2 + ...-included-in-tree-chain-expected-blink.txt | 9 ++-- ...ontent-visibility-label-expected-blink.txt | 2 + .../missing-parent-expected-blink.txt | 4 ++ .../slot-creation-crash-expected-blink.txt | 1 + .../title-in-shadow-expected-blink.txt | 1 + .../modules/accessibility/ax_object.cc | 51 ++++++++++++------ .../accessibility/ax_selection_test.cc | 53 ++++++++++++------- .../element-role-mapping-normal-expected.txt | 4 ++ .../parent-is-included-in-tree.html | 4 +- ...-getFullAXTree-display-locked-expected.txt | 2 + .../accessibility-ignoredNodes-expected.txt | 6 ++- .../accessibility-query-axtree-expected.txt | 24 +++++++++ .../content-visibility-accessibility-001.html | 12 +++-- .../content-visibility-accessibility-002.html | 17 ++++-- .../content-visibility-accessibility-003.html | 9 ++-- .../content-visibility-accessibility-004.html | 13 +++-- .../content-visibility-accessibility-005.html | 8 ++- .../content-visibility-accessibility-008.html | 5 +- 77 files changed, 407 insertions(+), 97 deletions(-) diff --git a/content/test/data/accessibility/aria/aria-empty-string-expected-blink.txt b/content/test/data/accessibility/aria/aria-empty-string-expected-blink.txt index 6028f031a2f15..f5d6531d43cab 100644 --- a/content/test/data/accessibility/aria/aria-empty-string-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-empty-string-expected-blink.txt @@ -26,3 +26,4 @@ rootWebArea ++++++grid ++++++++columnHeader name='Sort undefined' ++++++group name='Hidden undefined, display block' +++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/aria/aria-hidden-expected-blink.txt b/content/test/data/accessibility/aria/aria-hidden-expected-blink.txt index eec655e267e49..03448c0af5879 100644 --- a/content/test/data/accessibility/aria/aria-hidden-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-hidden-expected-blink.txt @@ -5,14 +5,18 @@ rootWebArea isLineBreakingObject=true ++++++++staticText name='blockDisplay' ++++++++++inlineTextBox name='blockDisplay' ++++++genericContainer ignored invisible +++++++++staticText ignored name='noneDisplay' ++++++genericContainer ignored invisible isLineBreakingObject=true ++++++++staticText ignored invisible name='blockDisplay Hiddentrue' ++++++genericContainer ignored invisible +++++++++staticText ignored invisible name='noneDisplay Hiddentrue' ++++++genericContainer isLineBreakingObject=true ++++++++staticText name='blockDisplay Hiddenfalse' ++++++++++inlineTextBox name='blockDisplay Hiddenfalse' ++++++genericContainer invisible +++++++++staticText ignored name='noneDisplay Hiddenfalse' ++++++genericContainer invisible name='blockDisplay Hiddentruefocusable' isLineBreakingObject=true ++++++++staticText ignored invisible name='blockDisplay Hiddentruefocusable' ++++++genericContainer ignored invisible ++++++++heading invisible name='noneDisplayParent Hiddenfalse' isLineBreakingObject=true +++++++++++staticText ignored name='noneDisplayParent Hiddenfalse' diff --git a/content/test/data/accessibility/aria/aria-hidden-single-descendant-display-none-expected-blink.txt b/content/test/data/accessibility/aria/aria-hidden-single-descendant-display-none-expected-blink.txt index 22a0c6883878e..7078e3a963737 100644 --- a/content/test/data/accessibility/aria/aria-hidden-single-descendant-display-none-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-hidden-single-descendant-display-none-expected-blink.txt @@ -1,5 +1,11 @@ rootWebArea ++genericContainer ignored ++++genericContainer ignored -++++++genericContainer invisible +++++++genericContainer ignored invisible +++++++++genericContainer ignored invisible +++++++++++button ignored invisible +++++++++++++staticText ignored invisible name='expect invisible subtree' +++++++++genericContainer invisible +++++++++++button ignored invisible +++++++++++++staticText ignored name='expect invisible subtree' ++++++group name='Done' diff --git a/content/test/data/accessibility/aria/aria-hidden-single-descendant-visibility-hidden-expected-blink.txt b/content/test/data/accessibility/aria/aria-hidden-single-descendant-visibility-hidden-expected-blink.txt index 4acbc037c333e..5366182462bcb 100644 --- a/content/test/data/accessibility/aria/aria-hidden-single-descendant-visibility-hidden-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-hidden-single-descendant-visibility-hidden-expected-blink.txt @@ -6,6 +6,8 @@ rootWebArea ++++++++++button ignored invisible ++++++++++++staticText ignored invisible name='expect invisible subtree' ++++++++genericContainer invisible +++++++++++button ignored invisible +++++++++++++staticText ignored invisible name='expect invisible subtree' ++++++++genericContainer ignored invisible ++++++++++button invisible name='expect invisible subtree' ++++++++++++staticText ignored invisible name='expect invisible subtree' diff --git a/content/test/data/accessibility/aria/aria-owns-crash-expected-blink.txt b/content/test/data/accessibility/aria/aria-owns-crash-expected-blink.txt index 4ad6e7d1ad26b..4a8ba7c8af7c7 100644 --- a/content/test/data/accessibility/aria/aria-owns-crash-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-owns-crash-expected-blink.txt @@ -4,9 +4,11 @@ rootWebArea name='done' ++++++genericContainer ignored invisible ++++++++genericContainer ignored invisible ++++++++++comboBoxGrouping ignored invisible -++++++++++++genericContainer ignored invisible +++++++++++++textField ignored invisible +++++++++++++++genericContainer ignored invisible ++++++++++++listBox ignored invisible ++++++++++++++none ignored invisible ++++++++++++++++none ignored invisible ++++++++++++++++++staticText ignored name='%E2%80%A2 ' +++++++++++++++++staticText ignored invisible name='Test' ++++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/aria/aria-undefined-expected-blink.txt b/content/test/data/accessibility/aria/aria-undefined-expected-blink.txt index 9e8e9411b5b8d..868c386fd9763 100644 --- a/content/test/data/accessibility/aria/aria-undefined-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-undefined-expected-blink.txt @@ -26,3 +26,4 @@ rootWebArea ++++++grid ++++++++columnHeader name='Sort undefined' ++++++group name='Hidden undefined, display block' +++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/aria/aria-undefined-literal-expected-blink.txt b/content/test/data/accessibility/aria/aria-undefined-literal-expected-blink.txt index f597f927fe946..1cccaa17f9b2b 100644 --- a/content/test/data/accessibility/aria/aria-undefined-literal-expected-blink.txt +++ b/content/test/data/accessibility/aria/aria-undefined-literal-expected-blink.txt @@ -26,3 +26,4 @@ rootWebArea ++++++grid ++++++++columnHeader name='Sort undefined' ++++++group name='Hidden undefined, display block' +++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/aria/hidden-described-by-expected-blink.txt b/content/test/data/accessibility/aria/hidden-described-by-expected-blink.txt index 15814f6873b7d..76a3b424376c0 100644 --- a/content/test/data/accessibility/aria/hidden-described-by-expected-blink.txt +++ b/content/test/data/accessibility/aria/hidden-described-by-expected-blink.txt @@ -3,7 +3,8 @@ rootWebArea ++++genericContainer ignored ++++++genericContainer ignored ++++++++genericContainer ignored invisible -++++++++genericContainer description='span-A4' name='span-A3' descriptionFrom=relatedElement ++++++++++genericContainer ignored invisible +++++++++++genericContainer description='span-A4' name='span-A3' descriptionFrom=relatedElement +++++++++++++genericContainer ignored invisible ++++++++genericContainer description='span-A2' name='span-B' descriptionFrom=relatedElement ++++++++genericContainer name='span-C' diff --git a/content/test/data/accessibility/aria/hidden-expected-blink.txt b/content/test/data/accessibility/aria/hidden-expected-blink.txt index 66c13fbc97e74..fca90d2262539 100644 --- a/content/test/data/accessibility/aria/hidden-expected-blink.txt +++ b/content/test/data/accessibility/aria/hidden-expected-blink.txt @@ -2,5 +2,7 @@ rootWebArea ++genericContainer ignored ++++genericContainer ignored ++++++genericContainer ignored +++++++++genericContainer ignored invisible +++++++++++genericContainer ignored invisible ++++++++genericContainer description='b' ++++++++genericContainer description='c' diff --git a/content/test/data/accessibility/aria/hidden-labelled-by-expected-blink.txt b/content/test/data/accessibility/aria/hidden-labelled-by-expected-blink.txt index a865ea0591691..143e69714b82e 100644 --- a/content/test/data/accessibility/aria/hidden-labelled-by-expected-blink.txt +++ b/content/test/data/accessibility/aria/hidden-labelled-by-expected-blink.txt @@ -3,7 +3,8 @@ rootWebArea ++++genericContainer ignored ++++++genericContainer ignored ++++++++genericContainer ignored invisible -++++++++group name='span-A4' ++++++++++genericContainer ignored invisible +++++++++++group name='span-A4' +++++++++++++genericContainer ignored invisible ++++++++group name='span-A2' ++++++++genericContainer name='span-C' diff --git a/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt b/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt index 93c34fd82b020..04612b2a12eda 100644 --- a/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt +++ b/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt @@ -11,6 +11,7 @@ rootWebArea ++++++++++++++staticText name='Day' ++++++++++++++++inlineTextBox name='Day' ++++++++++++columnHeader ignored invisible +++++++++++++++staticText ignored name='Year' ++++++++++++columnHeader name='Weather' ariaCellColumnIndex=5 ariaCellRowIndex=2 ++++++++++++++staticText name='Weather' ++++++++++++++++inlineTextBox name='Weather' @@ -22,6 +23,7 @@ rootWebArea ++++++++++++++staticText name='01' ++++++++++++++++inlineTextBox name='01' ++++++++++++cell ignored invisible +++++++++++++++staticText ignored name='2017' ++++++++++++cell name='Sunny' ariaCellColumnIndex=5 ariaCellRowIndex=3 ++++++++++++++staticText name='Sunny' ++++++++++++++++inlineTextBox name='Sunny' @@ -33,6 +35,7 @@ rootWebArea ++++++++++++++staticText name='02' ++++++++++++++++inlineTextBox name='02' ++++++++++++cell ignored invisible +++++++++++++++staticText ignored name='2017' ++++++++++++cell name='Rainy' ariaCellColumnIndex=5 ariaCellRowIndex=4 ++++++++++++++staticText name='Rainy' ++++++++++++++++inlineTextBox name='Rainy' diff --git a/content/test/data/accessibility/css/alt-text-expected-blink.txt b/content/test/data/accessibility/css/alt-text-expected-blink.txt index d8b9c9e73b5a8..d7637699937b1 100644 --- a/content/test/data/accessibility/css/alt-text-expected-blink.txt +++ b/content/test/data/accessibility/css/alt-text-expected-blink.txt @@ -58,6 +58,7 @@ rootWebArea ++++++++++staticText name='Some Text' ++++++++++++inlineTextBox name='Some Text' ++++++image name='alt' +++++++++staticText ignored name='Div text content' ++++++genericContainer ++++++++staticText name='DOM Text' ++++++++++inlineTextBox name='DOM Text' diff --git a/content/test/data/accessibility/css/content-visibility-auto-aria-hidden-expected-blink.txt b/content/test/data/accessibility/css/content-visibility-auto-aria-hidden-expected-blink.txt index 42459b59b0edd..5f95011d82df9 100644 --- a/content/test/data/accessibility/css/content-visibility-auto-aria-hidden-expected-blink.txt +++ b/content/test/data/accessibility/css/content-visibility-auto-aria-hidden-expected-blink.txt @@ -2,5 +2,7 @@ rootWebArea name='Done' ++genericContainer ignored ++++genericContainer ignored ++++++genericContainer +++++++++genericContainer ignored invisible +++++++++++staticText ignored invisible name='aria-hidden' ++++++++genericContainer ++++++++++staticText name='Not hidden' diff --git a/content/test/data/accessibility/css/content-visibility-hidden-check-failure-expected-blink.txt b/content/test/data/accessibility/css/content-visibility-hidden-check-failure-expected-blink.txt index b3d9221cc3954..90377f5548c8d 100644 --- a/content/test/data/accessibility/css/content-visibility-hidden-check-failure-expected-blink.txt +++ b/content/test/data/accessibility/css/content-visibility-hidden-check-failure-expected-blink.txt @@ -1,2 +1,4 @@ rootWebArea ++genericContainer ignored invisible +++++genericContainer ignored invisible +++++++staticText ignored invisible name='' diff --git a/content/test/data/accessibility/css/content-visibility-to-hidden-expected-blink.txt b/content/test/data/accessibility/css/content-visibility-to-hidden-expected-blink.txt index 39204e0402114..c8bdd7a5e056f 100644 --- a/content/test/data/accessibility/css/content-visibility-to-hidden-expected-blink.txt +++ b/content/test/data/accessibility/css/content-visibility-to-hidden-expected-blink.txt @@ -3,5 +3,10 @@ rootWebArea name='done' ++++genericContainer ignored ++++++genericContainer ++++++++group className='hidden' name='Label' +++++++++++staticText ignored invisible name=' target ' ++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name=' child ' +++++++++++staticText ignored invisible name=' ' ++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name='Label' +++++++++++staticText ignored invisible name=' ' diff --git a/content/test/data/accessibility/css/display-none-expected-blink.txt b/content/test/data/accessibility/css/display-none-expected-blink.txt index 2306e8e2d8666..0e404a654e339 100644 --- a/content/test/data/accessibility/css/display-none-expected-blink.txt +++ b/content/test/data/accessibility/css/display-none-expected-blink.txt @@ -2,3 +2,7 @@ rootWebArea ++genericContainer ignored ++++genericContainer ignored ++++++genericContainer ignored invisible +++++++++link ignored invisible +++++++++++staticText ignored name='One' +++++++++link ignored invisible +++++++++++staticText ignored name='Two' diff --git a/content/test/data/accessibility/css/dom-element-css-alternative-text-expected-blink.txt b/content/test/data/accessibility/css/dom-element-css-alternative-text-expected-blink.txt index c1e4fc766ab31..df9e9396b8f08 100644 --- a/content/test/data/accessibility/css/dom-element-css-alternative-text-expected-blink.txt +++ b/content/test/data/accessibility/css/dom-element-css-alternative-text-expected-blink.txt @@ -2,3 +2,4 @@ rootWebArea ++genericContainer ignored ++++genericContainer ++++++image name='alternative text' +++++++++staticText ignored name='DOM text' diff --git a/content/test/data/accessibility/css/visibility-expected-blink.txt b/content/test/data/accessibility/css/visibility-expected-blink.txt index 55fa83999ca3f..8fe462a25b309 100644 --- a/content/test/data/accessibility/css/visibility-expected-blink.txt +++ b/content/test/data/accessibility/css/visibility-expected-blink.txt @@ -2,8 +2,10 @@ rootWebArea ++genericContainer ignored ++++genericContainer ignored ++++++paragraph ignored invisible +++++++++staticText ignored invisible name='Hidden paragraph with ' ++++++++staticText name='visible link' ++++++++++inlineTextBox name='visible link' ++++++paragraph ignored invisible +++++++++staticText ignored invisible name='Collapsed paragraph with ' ++++++++staticText name='visible link' ++++++++++inlineTextBox name='visible link' \ No newline at end of file diff --git a/content/test/data/accessibility/css/visibility-to-hidden-expected-blink.txt b/content/test/data/accessibility/css/visibility-to-hidden-expected-blink.txt index 46cbb387fa704..5a76ffebb2146 100644 --- a/content/test/data/accessibility/css/visibility-to-hidden-expected-blink.txt +++ b/content/test/data/accessibility/css/visibility-to-hidden-expected-blink.txt @@ -5,6 +5,7 @@ rootWebArea ++++++++staticText name='Cats ' ++++++++++inlineTextBox name='Cats ' ++++++++genericContainer ignored invisible +++++++++++checkBox ignored invisible ++++++++genericContainer ++++++++++staticText name='done' ++++++++++++inlineTextBox name='done' diff --git a/content/test/data/accessibility/display-locking/all-expected-blink.txt b/content/test/data/accessibility/display-locking/all-expected-blink.txt index 758d45a458741..1598c7d79d73f 100644 --- a/content/test/data/accessibility/display-locking/all-expected-blink.txt +++ b/content/test/data/accessibility/display-locking/all-expected-blink.txt @@ -16,8 +16,10 @@ rootWebArea ++++++++staticText offscreen name='normal text 1' ++++++++++inlineTextBox offscreen name='normal text 1' ++++++++genericContainer offscreen +++++++++++staticText ignored invisible offscreen name=' nested non-viewport-activatable locked element will not be in AX tree ' ++++++++staticText offscreen name='normal text 2' ++++++++++inlineTextBox offscreen name='normal text 2' ++++++++genericContainer offscreen +++++++++++staticText ignored invisible offscreen name=' nested non-activatable locked element will not be in AX tree ' ++++++++staticText offscreen name='normal text 3' ++++++++++inlineTextBox offscreen name='normal text 3' diff --git a/content/test/data/accessibility/display-locking/non-activatable-expected-blink.txt b/content/test/data/accessibility/display-locking/non-activatable-expected-blink.txt index e7f6fda9fbdf1..52c3e7645c7fa 100644 --- a/content/test/data/accessibility/display-locking/non-activatable-expected-blink.txt +++ b/content/test/data/accessibility/display-locking/non-activatable-expected-blink.txt @@ -3,5 +3,13 @@ rootWebArea ++++genericContainer ignored ++++++genericContainer ignored ++++++++genericContainer +++++++++++staticText ignored invisible name=' ' ++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name='child' +++++++++++staticText ignored invisible name=' ' ++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name='nested locked element!' +++++++++++staticText ignored invisible name=' ' +++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name='activatable locked element' +++++++++++staticText ignored invisible name=' ' diff --git a/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win.txt b/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win.txt index 01f26d4c58a78..aabb8f57a352b 100644 --- a/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win.txt +++ b/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win.txt @@ -4,5 +4,4 @@ AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox Level changed on role=heading, name=Described by dialog title StructureChanged/ChildAdded on role=dialog -StructureChanged/ChildrenReordered on role=dialog -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win7.txt b/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win7.txt index e44a4870939d4..1486541735edf 100644 --- a/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win7.txt +++ b/content/test/data/accessibility/event/add-dialog-described-by-expected-uia-win7.txt @@ -3,5 +3,4 @@ AriaProperties changed on role=heading, name=Described by dialog title AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox StructureChanged/ChildAdded on role=dialog -StructureChanged/ChildrenReordered on role=dialog -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-described-by-expected-win.txt b/content/test/data/accessibility/event/add-dialog-described-by-expected-win.txt index ae01d624dcc53..8753b829f8328 100644 --- a/content/test/data/accessibility/event/add-dialog-described-by-expected-win.txt +++ b/content/test/data/accessibility/event/add-dialog-described-by-expected-win.txt @@ -1,4 +1,3 @@ EVENT_OBJECT_REORDER on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE -EVENT_OBJECT_REORDER on
role=ROLE_SYSTEM_GROUPING EVENT_OBJECT_SHOW on role=ROLE_SYSTEM_DIALOG -IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} \ No newline at end of file +IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} diff --git a/content/test/data/accessibility/event/add-dialog-expected-uia-win.txt b/content/test/data/accessibility/event/add-dialog-expected-uia-win.txt index 901b07690c94b..b4cf0924497dc 100644 --- a/content/test/data/accessibility/event/add-dialog-expected-uia-win.txt +++ b/content/test/data/accessibility/event/add-dialog-expected-uia-win.txt @@ -4,5 +4,4 @@ AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox Level changed on role=heading, name=Dialog title StructureChanged/ChildAdded on role=dialog, name=Dialog title -StructureChanged/ChildrenReordered on role=dialog, name=Dialog title -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-expected-uia-win7.txt b/content/test/data/accessibility/event/add-dialog-expected-uia-win7.txt index fd68ac34be616..7905d6a385ea9 100644 --- a/content/test/data/accessibility/event/add-dialog-expected-uia-win7.txt +++ b/content/test/data/accessibility/event/add-dialog-expected-uia-win7.txt @@ -3,5 +3,4 @@ AriaProperties changed on role=heading, name=Dialog title AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox StructureChanged/ChildAdded on role=dialog, name=Dialog title -StructureChanged/ChildrenReordered on role=dialog, name=Dialog title -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-expected-win.txt b/content/test/data/accessibility/event/add-dialog-expected-win.txt index f59bb0f43f34f..0c5f22d4e5d67 100644 --- a/content/test/data/accessibility/event/add-dialog-expected-win.txt +++ b/content/test/data/accessibility/event/add-dialog-expected-win.txt @@ -1,4 +1,3 @@ EVENT_OBJECT_REORDER on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE -EVENT_OBJECT_REORDER on
role=ROLE_SYSTEM_GROUPING EVENT_OBJECT_SHOW on role=ROLE_SYSTEM_DIALOG name="Dialog title" -IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} \ No newline at end of file +IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} diff --git a/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win.txt b/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win.txt index aa6af833078ba..4457fa2155d49 100644 --- a/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win.txt +++ b/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win.txt @@ -4,5 +4,4 @@ AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox Level changed on role=heading, name=Dialog title StructureChanged/ChildAdded on role=dialog -StructureChanged/ChildrenReordered on role=dialog -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win7.txt b/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win7.txt index 2994b4da5bade..6145419e3ad21 100644 --- a/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win7.txt +++ b/content/test/data/accessibility/event/add-dialog-no-info-expected-uia-win7.txt @@ -3,5 +3,4 @@ AriaProperties changed on role=heading, name=Dialog title AriaProperties changed on role=textbox IsDataValidForForm changed on role=textbox StructureChanged/ChildAdded on role=dialog -StructureChanged/ChildrenReordered on role=dialog -StructureChanged/ChildrenReordered on role=document \ No newline at end of file +StructureChanged/ChildrenReordered on role=document diff --git a/content/test/data/accessibility/event/add-dialog-no-info-expected-win.txt b/content/test/data/accessibility/event/add-dialog-no-info-expected-win.txt index 321fad7fae329..b2352f24464b7 100644 --- a/content/test/data/accessibility/event/add-dialog-no-info-expected-win.txt +++ b/content/test/data/accessibility/event/add-dialog-no-info-expected-win.txt @@ -1,4 +1,3 @@ EVENT_OBJECT_REORDER on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE -EVENT_OBJECT_REORDER on
role=ROLE_SYSTEM_GROUPING EVENT_OBJECT_SHOW on role=ROLE_SYSTEM_DIALOG -IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} \ No newline at end of file +IA2_EVENT_TEXT_INSERTED on <#document> role=ROLE_SYSTEM_DOCUMENT value~=[doc-url] FOCUSED,FOCUSABLE new_text={'' start=0 end=1} diff --git a/content/test/data/accessibility/event/aria-hidden-single-descendant-visibility-hidden-expected-auralinux.txt b/content/test/data/accessibility/event/aria-hidden-single-descendant-visibility-hidden-expected-auralinux.txt index fd41b9fa03e11..e422ec16f6cd1 100644 --- a/content/test/data/accessibility/event/aria-hidden-single-descendant-visibility-hidden-expected-auralinux.txt +++ b/content/test/data/accessibility/event/aria-hidden-single-descendant-visibility-hidden-expected-auralinux.txt @@ -1,8 +1,6 @@ CHILDREN-CHANGED:REMOVE index:0 CHILD:(role=ROLE_SECTION) role=ROLE_DOCUMENT_WEB ENABLED,FOCUSABLE,FOCUSED,SENSITIVE,SHOWING,VISIBLE === Start Continuation === CHILDREN-CHANGED:ADD index:0 CHILD:(role=ROLE_SECTION) role=ROLE_DOCUMENT_WEB ENABLED,FOCUSABLE,FOCUSED,SENSITIVE,SHOWING,VISIBLE -STATE-CHANGE:DEFUNCT:TRUE role=ROLE_INVALID name='(null)' DEFUNCT -STATE-CHANGE:DEFUNCT:TRUE role=ROLE_INVALID name='(null)' DEFUNCT === Start Continuation === CHILDREN-CHANGED:REMOVE index:1 CHILD:(role=ROLE_SECTION) role=ROLE_DOCUMENT_WEB ENABLED,FOCUSABLE,FOCUSED,SENSITIVE,SHOWING,VISIBLE PARENT-CHANGED PARENT:(role=ROLE_DOCUMENT_WEB name='(null)') role=ROLE_PUSH_BUTTON name='expect invisible subtree' ENABLED,FOCUSABLE,SENSITIVE diff --git a/content/test/data/accessibility/html/accordion-expected-blink.txt b/content/test/data/accessibility/html/accordion-expected-blink.txt index ef4bc51bf1883..d7822fa841dff 100644 --- a/content/test/data/accessibility/html/accordion-expected-blink.txt +++ b/content/test/data/accessibility/html/accordion-expected-blink.txt @@ -16,12 +16,16 @@ rootWebArea ++++++++++++staticText name='Accordion Section #2' ++++++++++++++inlineTextBox name='Accordion Section #2' ++++++region ignored invisible +++++++++paragraph ignored invisible +++++++++++staticText ignored name='Content for second section of accordion element.' ++++++heading name='Accordion Section #3' ++++++++button collapsed name='Accordion Section #3' controlsIds= ++++++++++paragraph ++++++++++++staticText name='Accordion Section #3' ++++++++++++++inlineTextBox name='Accordion Section #3' ++++++region ignored invisible +++++++++paragraph ignored invisible +++++++++++staticText ignored name='Content for third section of accordion element.' ++++++heading name='Accordion Section #4' ++++++++button expanded name='Accordion Section #4' restriction=disabled ++++++++++paragraph diff --git a/content/test/data/accessibility/html/custom-element-expected-blink.txt b/content/test/data/accessibility/html/custom-element-expected-blink.txt index 9f07f97e8b150..e4ba329034293 100644 --- a/content/test/data/accessibility/html/custom-element-expected-blink.txt +++ b/content/test/data/accessibility/html/custom-element-expected-blink.txt @@ -5,8 +5,16 @@ rootWebArea ++++++genericContainer ++++++++staticText name='a' ++++++++++inlineTextBox name='a' +++++++++genericContainer ignored invisible +++++++++++staticText ignored name='b' +++++++++genericContainer ignored invisible +++++++++++staticText ignored invisible name='c' ++++++splitter horizontal name='Inside custom element' ++++++genericContainer ignored ++++++++genericContainer ignored ++++++++++staticText name='a' -++++++++++++inlineTextBox name='a' \ No newline at end of file +++++++++++++inlineTextBox name='a' +++++++++++genericContainer ignored invisible +++++++++++++staticText ignored name='b' +++++++++++genericContainer ignored invisible +++++++++++++staticText ignored invisible name='c' diff --git a/content/test/data/accessibility/html/custom-element-hidden-expected-blink.txt b/content/test/data/accessibility/html/custom-element-hidden-expected-blink.txt index b39a6d3ae97d1..9db06e2f2a933 100644 --- a/content/test/data/accessibility/html/custom-element-hidden-expected-blink.txt +++ b/content/test/data/accessibility/html/custom-element-hidden-expected-blink.txt @@ -2,6 +2,7 @@ rootWebArea htmlTag='#document' ++genericContainer ignored htmlTag='html' ++++genericContainer htmlTag='body' ++++++genericContainer ignored invisible htmlTag='template' -++++++genericContainer ignored invisible htmlTag='my-element' -++++++++genericContainer ignored invisible htmlTag='div' +++++++genericContainer ignored invisible htmlTag='div' +++++++++genericContainer ignored invisible htmlTag='my-element' +++++++++++genericContainer ignored invisible htmlTag='div' ++++++button htmlTag='button' name='Done' diff --git a/content/test/data/accessibility/html/custom-element-with-aria-owns-inside-expected-blink.txt b/content/test/data/accessibility/html/custom-element-with-aria-owns-inside-expected-blink.txt index 571e9dd2d408c..acc84e909526c 100644 --- a/content/test/data/accessibility/html/custom-element-with-aria-owns-inside-expected-blink.txt +++ b/content/test/data/accessibility/html/custom-element-with-aria-owns-inside-expected-blink.txt @@ -10,4 +10,6 @@ rootWebArea ++++++++++++staticText name='Endnote 2' ++++++++++++++inlineTextBox name='Endnote 2' ++++++++button ignored invisible -++++++++button ignored invisible \ No newline at end of file +++++++++++staticText ignored name='1' +++++++++button ignored invisible +++++++++++staticText ignored name='2' diff --git a/content/test/data/accessibility/html/details-expected-blink.txt b/content/test/data/accessibility/html/details-expected-blink.txt index 742e850419cdb..30bb0ace60902 100644 --- a/content/test/data/accessibility/html/details-expected-blink.txt +++ b/content/test/data/accessibility/html/details-expected-blink.txt @@ -12,6 +12,7 @@ rootWebArea ++++++++++staticText ignored invisible name=' ' ++++++++++staticText ignored invisible name=' ' ++++++++++paragraph ignored invisible +++++++++++++staticText ignored invisible name='The details tag specifies additional details that the user can view or hide on demand.' ++++++++++staticText ignored invisible name=' ' ++++++details ++++++++genericContainer ignored diff --git a/content/test/data/accessibility/html/generated-content-after-hidden-input-expected-blink.txt b/content/test/data/accessibility/html/generated-content-after-hidden-input-expected-blink.txt index b1bdc71ed8e81..4a5c3ddf88f84 100644 --- a/content/test/data/accessibility/html/generated-content-after-hidden-input-expected-blink.txt +++ b/content/test/data/accessibility/html/generated-content-after-hidden-input-expected-blink.txt @@ -2,7 +2,8 @@ rootWebArea ++genericContainer ignored ++++genericContainer ignored ++++++paragraph -++++++++genericContainer ignored invisible +++++++++textField ignored invisible +++++++++++genericContainer ignored invisible ++++++++genericContainer ignored ++++++++++staticText name='*' ++++++++++++inlineTextBox name='*' diff --git a/content/test/data/accessibility/html/iframe-with-invalid-children-added-expected-blink.txt b/content/test/data/accessibility/html/iframe-with-invalid-children-added-expected-blink.txt index b4ab399598641..f15eb2f0894b5 100644 --- a/content/test/data/accessibility/html/iframe-with-invalid-children-added-expected-blink.txt +++ b/content/test/data/accessibility/html/iframe-with-invalid-children-added-expected-blink.txt @@ -12,3 +12,4 @@ rootWebArea name='done' ++++++++labelText ignored ++++++++++staticText ignored name='label' ++++++++++textField ignored +++++++++++++genericContainer ignored diff --git a/content/test/data/accessibility/html/input-list-expected-blink.txt b/content/test/data/accessibility/html/input-list-expected-blink.txt index 199de31dba076..1af48005e52fb 100644 --- a/content/test/data/accessibility/html/input-list-expected-blink.txt +++ b/content/test/data/accessibility/html/input-list-expected-blink.txt @@ -11,4 +11,3 @@ rootWebArea focusable ++++++++++++listItem ignored invisible ++++++++++++++listMarker ignored invisible ++++++++++++++++staticText ignored invisible name='%E2%96%BE' -++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt b/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt index 1a2d375c4fd9c..21a8bf92fda4c 100644 --- a/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt +++ b/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt @@ -8,4 +8,3 @@ rootWebArea ++++++++++listItem ignored invisible ++++++++++++listMarker ignored invisible ++++++++++++++staticText ignored invisible name='%E2%96%BE' -++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/html/landmark-expected-blink.txt b/content/test/data/accessibility/html/landmark-expected-blink.txt index f87fadc21c6fe..8ec3792d7c60d 100644 --- a/content/test/data/accessibility/html/landmark-expected-blink.txt +++ b/content/test/data/accessibility/html/landmark-expected-blink.txt @@ -75,6 +75,7 @@ rootWebArea ++++++++++++++inlineTextBox name='Details' ++++++++genericContainer ignored ++++++++++headerAsNonLandmark ignored invisible +++++++++++++staticText ignored invisible name='This should NOT header role.' ++++++group ++++++++headerAsNonLandmark ++++++++++staticText name='This should NOT have banner role.' @@ -128,6 +129,8 @@ rootWebArea ++++++++++++++inlineTextBox name='Details' ++++++++genericContainer ignored ++++++++++genericContainer ignored invisible +++++++++++++headerAsNonLandmark ignored invisible +++++++++++++++staticText ignored invisible name='This should NOT header role.' ++++++group ++++++++genericContainer ignored ++++++++++headerAsNonLandmark @@ -180,6 +183,7 @@ rootWebArea ++++++++++++++inlineTextBox name='Details' ++++++++genericContainer ignored ++++++++++footerAsNonLandmark ignored invisible +++++++++++++staticText ignored invisible name='This should NOT footer role.' ++++++group ++++++++footerAsNonLandmark ++++++++++staticText name='This should NOT have footer role.' @@ -233,6 +237,8 @@ rootWebArea ++++++++++++++inlineTextBox name='Details' ++++++++genericContainer ignored ++++++++++genericContainer ignored invisible +++++++++++++footerAsNonLandmark ignored invisible +++++++++++++++staticText ignored invisible name='This should NOT footer role.' ++++++group ++++++++genericContainer ignored ++++++++++footerAsNonLandmark diff --git a/content/test/data/accessibility/html/meter-expected-blink.txt b/content/test/data/accessibility/html/meter-expected-blink.txt index 62121ece64f89..3396f991a8bbe 100644 --- a/content/test/data/accessibility/html/meter-expected-blink.txt +++ b/content/test/data/accessibility/html/meter-expected-blink.txt @@ -5,3 +5,4 @@ rootWebArea ++++++++genericContainer ++++++++++genericContainer ++++++++++++genericContainer ignored +++++++++genericContainer ignored invisible diff --git a/content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt b/content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt index 167f94a03fae3..8b65e57dd03f3 100644 --- a/content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt +++ b/content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt @@ -4,6 +4,8 @@ rootWebArea ++++++staticText name='Test that elements respawn in the accessibility tree after a modal dialog closes.' ++++++++inlineTextBox name='Test that elements respawn in the accessibility tree after a modal dialog closes.' ++++++section +++++++++dialog ignored invisible +++++++++++staticText ignored name='This dialog is closed and should not be in the tree' ++++++++popUpButton collapsed value='This should be in the tree.' haspopup=menu ++++++++++menuListPopup invisible ++++++++++++menuListOption name='This should be in the tree.' selected=true diff --git a/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt b/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt index e46b504bfa696..c9779a594d123 100644 --- a/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt +++ b/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt @@ -3,9 +3,11 @@ rootWebArea ++++genericContainer ignored invisible ++++++section ignored invisible ++++++++dialog ignored invisible +++++++++++staticText ignored name=' This was the top dialog and should be marked ignored in the tree. ' ++++++++menuListPopup ignored invisible ++++++++++menuListOption ignored ++++++dialog ignored invisible +++++++++staticText ignored name=' This was the middle dialog and should be marked ignored in the tree.' ++++++dialog ++++++++staticText name='This is the now active dialog. Of course it should be in the tree. ' ++++++++++inlineTextBox name='This is the now active dialog. Of course it should be in the tree. ' diff --git a/content/test/data/accessibility/html/modal-dialog-stack.html b/content/test/data/accessibility/html/modal-dialog-stack.html index 0f35db3ecd392..d019dd74c1ea3 100644 --- a/content/test/data/accessibility/html/modal-dialog-stack.html +++ b/content/test/data/accessibility/html/modal-dialog-stack.html @@ -7,7 +7,7 @@ Test the accessibility tree after a pending modal dialog becomes active.
- This was the top dialog and should not be in the tree. + This was the top dialog and should be marked ignored in the tree.