From 3fe845b724f1a76672f8b3da85536ea8e4c0ba51 Mon Sep 17 00:00:00 2001
From: Rubin Deliallisi <rubindl@chromium.org>
Date: Tue, 30 May 2023 09:17:31 +0000
Subject: [PATCH] Privacy Guide: Dynamic PS link visibility

- Dynamically remove the PS link in the completion step.

(cherry picked from commit 1120cf1b3aa4683d88b04694a8fb81e36203f016)

Bug: 1448806
Change-Id: Ib1359e2b90158bbc78ef2b6a6b183e62c5b0c1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567527
Reviewed-by: Nicola Tommasi <tommasin@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Rubin Deliallisi <rubindl@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149626}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571028
Auto-Submit: Nicola Tommasi <tommasin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nicola Tommasi <tommasin@chromium.org>
Reviewed-by: Rubin Deliallisi <rubindl@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{#126}
Cr-Branched-From: 1d71a337b1f6e707a13ae074dca1e2c34905eb9f-refs/heads/main@{#1148114}
---
 chrome/browser/privacy_guide/android/BUILD.gn |  1 +
 .../java/res/layout/privacy_guide_done.xml    |  2 +
 .../browser/privacy_guide/DoneFragment.java   | 11 +++-
 .../privacy_guide/DoneFragmentTest.java       | 65 +++++++++++++++++--
 4 files changed, 70 insertions(+), 9 deletions(-)

diff --git a/chrome/browser/privacy_guide/android/BUILD.gn b/chrome/browser/privacy_guide/android/BUILD.gn
index b3e4d0a11eeaf..5c0f54c7f9777 100644
--- a/chrome/browser/privacy_guide/android/BUILD.gn
+++ b/chrome/browser/privacy_guide/android/BUILD.gn
@@ -73,6 +73,7 @@ robolectric_library("junit") {
     "//base:base_java",
     "//base:base_java_test_support",
     "//base:base_junit_test_support",
+    "//chrome/browser/privacy_sandbox/android:java",
     "//chrome/browser/profiles/android:java",
     "//chrome/browser/safe_browsing/android:java",
     "//chrome/browser/signin/services/android:java",
diff --git a/chrome/browser/privacy_guide/android/java/res/layout/privacy_guide_done.xml b/chrome/browser/privacy_guide/android/java/res/layout/privacy_guide_done.xml
index 7eb3b8785384e..91dc91d99bcfb 100644
--- a/chrome/browser/privacy_guide/android/java/res/layout/privacy_guide_done.xml
+++ b/chrome/browser/privacy_guide/android/java/res/layout/privacy_guide_done.xml
@@ -41,11 +41,13 @@ found in the LICENSE file.
             style="@style/TextAppearance.TextLarge.Secondary" />
 
         <org.chromium.chrome.browser.privacy_guide.PrivacyGuideExplanationHeading
+            android:id="@+id/ps_heading"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             app:titleText="@string/privacy_guide_privacy_sandbox_heading" />
 
         <LinearLayout
+            android:id="@+id/ps_explanation"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginBottom="@dimen/done_step_explanation_marginBottom"
diff --git a/chrome/browser/privacy_guide/android/java/src/org/chromium/chrome/browser/privacy_guide/DoneFragment.java b/chrome/browser/privacy_guide/android/java/src/org/chromium/chrome/browser/privacy_guide/DoneFragment.java
index 9e46b1b0276b6..78b7db4b21f9d 100644
--- a/chrome/browser/privacy_guide/android/java/src/org/chromium/chrome/browser/privacy_guide/DoneFragment.java
+++ b/chrome/browser/privacy_guide/android/java/src/org/chromium/chrome/browser/privacy_guide/DoneFragment.java
@@ -21,6 +21,7 @@
 
 import org.chromium.base.IntentUtils;
 import org.chromium.chrome.browser.privacy_guide.PrivacyGuideUtils.CustomTabIntentHelper;
+import org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxBridge;
 import org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxReferrer;
 import org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxSettingsBaseFragment;
 import org.chromium.components.browser_ui.settings.SettingsLauncher;
@@ -45,8 +46,14 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ChromeImageButton psButton = view.findViewById(R.id.ps_button);
-        psButton.setOnClickListener(this::onPsButtonClick);
+        if (!PrivacySandboxBridge.isPrivacySandboxRestricted()
+                || PrivacySandboxBridge.isRestrictedNoticeEnabled()) {
+            ChromeImageButton psButton = view.findViewById(R.id.ps_button);
+            psButton.setOnClickListener(this::onPsButtonClick);
+        } else {
+            view.findViewById(R.id.ps_heading).setVisibility(View.GONE);
+            view.findViewById(R.id.ps_explanation).setVisibility(View.GONE);
+        }
 
         if (isUserSignedIn()) {
             ChromeImageButton waaButton = view.findViewById(R.id.waa_button);
diff --git a/chrome/browser/privacy_guide/android/junit/src/org/chromium/chrome/browser/privacy_guide/DoneFragmentTest.java b/chrome/browser/privacy_guide/android/junit/src/org/chromium/chrome/browser/privacy_guide/DoneFragmentTest.java
index 8ad9f3971d15a..9790ed153579c 100644
--- a/chrome/browser/privacy_guide/android/junit/src/org/chromium/chrome/browser/privacy_guide/DoneFragmentTest.java
+++ b/chrome/browser/privacy_guide/android/junit/src/org/chromium/chrome/browser/privacy_guide/DoneFragmentTest.java
@@ -23,6 +23,9 @@
 import org.mockito.junit.MockitoRule;
 
 import org.chromium.base.test.BaseRobolectricTestRunner;
+import org.chromium.base.test.util.JniMocker;
+import org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxBridge;
+import org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxBridgeJni;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.signin.services.IdentityServicesProvider;
 import org.chromium.components.signin.identitymanager.ConsentLevel;
@@ -35,6 +38,8 @@
 public class DoneFragmentTest {
     @Rule
     public MockitoRule mMockitoRule = MockitoJUnit.rule();
+    @Rule
+    public JniMocker mMocker = new JniMocker();
 
     @Mock
     private Profile mProfile;
@@ -42,14 +47,15 @@ public class DoneFragmentTest {
     private IdentityServicesProvider mIdentityServicesProvider;
     @Mock
     private IdentityManager mIdentityManager;
+    @Mock
+    private PrivacySandboxBridge.Natives mPrivacySandboxBridge;
 
     private FragmentScenario mScenario;
     private DoneFragment mFragment;
     private View mPsButton;
     private View mWaaButton;
 
-    private void initFragmentWithSignInState(boolean isSignedIn) {
-        when(mIdentityManager.hasPrimaryAccount(ConsentLevel.SIGNIN)).thenReturn(isSignedIn);
+    private void initFragment() {
         mScenario = FragmentScenario.launchInContainer(
                 DoneFragment.class, Bundle.EMPTY, R.style.Theme_MaterialComponents);
         mScenario.onFragment(fragment -> {
@@ -59,11 +65,22 @@ private void initFragmentWithSignInState(boolean isSignedIn) {
         });
     }
 
+    private void setSignedInState(boolean isSignedIn) {
+        when(mIdentityManager.hasPrimaryAccount(ConsentLevel.SIGNIN)).thenReturn(isSignedIn);
+    }
+
+    private void setPrivacySandboxState(boolean isRestricted, boolean isRestrictedNoticeEnabled) {
+        when(mPrivacySandboxBridge.isPrivacySandboxRestricted()).thenReturn(isRestricted);
+        when(mPrivacySandboxBridge.isRestrictedNoticeEnabled())
+                .thenReturn(isRestrictedNoticeEnabled);
+    }
+
     @Before
     public void setUp() {
         Profile.setLastUsedProfileForTesting(mProfile);
         IdentityServicesProvider.setInstanceForTests(mIdentityServicesProvider);
         when(mIdentityServicesProvider.getIdentityManager(mProfile)).thenReturn(mIdentityManager);
+        mMocker.mock(PrivacySandboxBridgeJni.TEST_HOOKS, mPrivacySandboxBridge);
     }
 
     @After
@@ -76,16 +93,50 @@ public void tearDown() {
     }
 
     @Test
-    public void testOneLinkVisibleWhenSignedOut() {
-        initFragmentWithSignInState(false);
+    public void testPSButtonNotVisible() {
+        setPrivacySandboxState(true, false);
+        initFragment();
+
+        assertFalse(mPsButton.isShown());
+    }
+
+    @Test
+    public void testPSButtonVisibleWhenNotRestricted() {
+        setPrivacySandboxState(false, false);
+        initFragment();
+
         assertTrue(mPsButton.isShown());
-        assertFalse(mWaaButton.isShown());
     }
 
     @Test
-    public void testTwoLinksVisibleWhenSignedIn() {
-        initFragmentWithSignInState(true);
+    public void testPSButtonVisibleWhenRestrictedNoticeEnabled() {
+        setPrivacySandboxState(true, true);
+        initFragment();
+
         assertTrue(mPsButton.isShown());
+    }
+
+    @Test
+    public void testPSButtonVisibleWhenNotRestrictedAndRestrictedNoticeEnabled() {
+        setPrivacySandboxState(false, true);
+        initFragment();
+
+        assertTrue(mPsButton.isShown());
+    }
+
+    @Test
+    public void testWaaButtonVisibleWhenSignedIn() {
+        setSignedInState(true);
+        initFragment();
+
         assertTrue(mWaaButton.isShown());
     }
+
+    @Test
+    public void testWaaButtonNotVisibleWhenNotSignedIn() {
+        setSignedInState(false);
+        initFragment();
+
+        assertFalse(mWaaButton.isShown());
+    }
 }