Fix Resource Timing Encoded Body Size overflow.

The existing 'encoded_body_length' in url_response_head.mojom is default
to -1. In some cases, this default value is not overwritten and is
propagated all the way to JS code and caused number overflow. See
details in the last comments of crbug.com/1324812.

This CL wraps the `encoded_body_length` without default value into a
struct which is made optional. This way, the case it is not set and it
is set to 0 and when it is not set, 0 would be used explicitly in the
downstream code.

Also the type of the field is changed into uint64_t to align with the V8
binding. And because uint64_t and int64 has different range, so
variables passed from and into the mojom field also changed their types.
Most of files touched are just of this change.

Bug: 1336219,1324812
Change-Id: I67f7bd3e47e4f71f719bab9b56cfaa9d388c6f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4126836
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091612}

Author: haoliuk

content/browser/devtools/devtools_url_loader_interceptor.cc

@@ -41,6 +41,8 @@
 #include "services/network/public/cpp/resource_request_body.h"
 #include "services/network/public/cpp/url_loader_completion_status.h"
 #include "services/network/public/mojom/early_hints.mojom.h"
+#include "services/network/public/mojom/encoded_body_length.mojom-forward.h"
+#include "services/network/public/mojom/encoded_body_length.mojom.h"
 #include "services/network/public/mojom/network_context.mojom.h"
 #include "services/network/public/mojom/url_loader.mojom.h"
 #include "third_party/blink/public/platform/resource_request_blocked_reason.h"
@@ -1220,7 +1222,7 @@ Response InterceptionJob::ProcessResponseOverride(
   size_t headers_size = head->headers->raw_headers().size();
   head->content_length = body_size;
   head->encoded_data_length = headers_size;
-  head->encoded_body_length = 0;
+  head->encoded_body_length = network::mojom::EncodedBodyLength::New(0u);
   head->request_start = start_ticks_;
   head->response_start = now_ticks;
 

content/public/test/render_view_test.cc

@@ -117,7 +117,7 @@ class FakeWebURLLoader : public blink::WebURLLoader {
       absl::optional<blink::WebURLError>&,
       blink::WebData&,
       int64_t&,
-      int64_t&,
+      uint64_t&,
       blink::WebBlobInfo&,
       std::unique_ptr<blink::ResourceLoadInfoNotifierWrapper>) override {
     client->DidFail(blink::WebURLError(kFailureReason, request->url),

services/network/public/mojom/BUILD.gn

@@ -342,6 +342,7 @@ mojom("url_loader_base") {
     "data_pipe_getter.mojom",
     "devtools_observer.mojom",
     "early_hints.mojom",
+    "encoded_body_length.mojom",
     "fetch_api.mojom",
     "http_raw_headers.mojom",
     "http_request_headers.mojom",

services/network/public/mojom/encoded_body_length.mojom

@@ -0,0 +1,11 @@
+// Copyright 2023 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module network.mojom;
+
+// This struct contains a encoded body length which is of type unsign long and
+// is used as an optional value.
+struct EncodedBodyLength {
+  uint64 value;
+};

services/network/public/mojom/url_response_head.mojom

@@ -7,6 +7,7 @@ module network.mojom;
 import "mojo/public/mojom/base/time.mojom";
 import "mojo/public/mojom/base/unguessable_token.mojom";
 import "services/network/public/mojom/alternate_protocol_usage.mojom";
+import "services/network/public/mojom/encoded_body_length.mojom";
 import "services/network/public/mojom/fetch_api.mojom";
 import "services/network/public/mojom/ip_address_space.mojom";
 import "services/network/public/mojom/ip_endpoint.mojom";
@@ -55,9 +56,9 @@ struct URLResponseHead {
   // no data, contains -1.
   int64 encoded_data_length = -1;
 
-  // Length of the response body data before decompression. -1 unless the body
-  // has been read to the end.
-  int64 encoded_body_length = -1;
+  // Length of the response body data before decompression. It is null unless
+  // the body has been read to the end.
+  network.mojom.EncodedBodyLength? encoded_body_length;
 
   // True if the request accessed the network in the process of retrieving data.
   bool network_accessed = false;

third_party/blink/public/platform/internet_disconnected_web_url_loader.h

@@ -55,7 +55,7 @@ class InternetDisconnectedWebURLLoader final : public WebURLLoader {
       absl::optional<WebURLError>&,
       WebData&,
       int64_t& encoded_data_length,
-      int64_t& encoded_body_length,
+      uint64_t& encoded_body_length,
       WebBlobInfo& downloaded_blob,
       std::unique_ptr<blink::ResourceLoadInfoNotifierWrapper>
           resource_load_info_notifier_wrapper) override;

third_party/blink/public/platform/web_url_loader.h

@@ -109,7 +109,7 @@ class BLINK_PLATFORM_EXPORT WebURLLoader {
       absl::optional<WebURLError>& error,
       WebData& data,
       int64_t& encoded_data_length,
-      int64_t& encoded_body_length,
+      uint64_t& encoded_body_length,
       WebBlobInfo& downloaded_blob,
       std::unique_ptr<ResourceLoadInfoNotifierWrapper>
           resource_load_info_notifier_wrapper);

third_party/blink/public/platform/web_url_loader_client.h

@@ -113,7 +113,7 @@ class BLINK_PLATFORM_EXPORT WebURLLoaderClient {
   virtual void DidFinishLoading(
       base::TimeTicks finish_time,
       int64_t total_encoded_data_length,
-      int64_t total_encoded_body_length,
+      uint64_t total_encoded_body_length,
       int64_t total_decoded_body_length,
       bool should_report_corb_blocking,
       absl::optional<bool> pervasive_payload_requested = absl::nullopt) {}
@@ -124,7 +124,7 @@ class BLINK_PLATFORM_EXPORT WebURLLoaderClient {
   virtual void DidFail(const WebURLError&,
                        base::TimeTicks finish_time,
                        int64_t total_encoded_data_length,
-                       int64_t total_encoded_body_length,
+                       uint64_t total_encoded_body_length,
                        int64_t total_decoded_body_length) {}
 
   // Value passed to DidFinishLoading when total encoded data length isn't

third_party/blink/public/platform/web_url_response.h

@@ -247,7 +247,7 @@ class BLINK_PLATFORM_EXPORT WebURLResponse {
 
   // Original size of the response body before decompression.
   int64_t EncodedBodyLength() const;
-  void SetEncodedBodyLength(int64_t);
+  void SetEncodedBodyLength(uint64_t);
 
   void SetIsSignedExchangeInnerResponse(bool);
   void SetWasInPrefetchCache(bool);

third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc

@@ -109,7 +109,7 @@ class NoopLoaderFactory final : public ResourceFetcher::LoaderFactory {
         absl::optional<WebURLError>&,
         WebData&,
         int64_t& encoded_data_length,
-        int64_t& encoded_body_length,
+        uint64_t& encoded_body_length,
         WebBlobInfo& downloaded_blob,
         std::unique_ptr<blink::ResourceLoadInfoNotifierWrapper>
             resource_load_info_notifier_wrapper) override {