From cb9d6a08a5713d7e12f0c5d6dc18684df9e2bab4 Mon Sep 17 00:00:00 2001 From: Liam Brady Date: Wed, 7 Jun 2023 23:18:04 +0000 Subject: [PATCH] [M115][Branch Gardener]Disable flaky FencedFrameInThreatDetails test. The test is flaking on Lacros builds. Disable it until a long term solution for the test is figured out. (cherry picked from commit 2a525ab6063a493a98d57232fac08ba71bd4a552) Bug: 1445499 Change-Id: I1ee6d87924b0bc6b40414e9ff07530179ebb8e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568531 Reviewed-by: Avi Drissman Commit-Queue: Liam Brady Cr-Original-Commit-Position: refs/heads/main@{#1149741} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598681 Auto-Submit: Elaine Chien Owners-Override: Elaine Chien Reviewed-by: Donn Denman Commit-Queue: Donn Denman Cr-Commit-Position: refs/branch-heads/5790@{#471} Cr-Branched-From: 1d71a337b1f6e707a13ae074dca1e2c34905eb9f-refs/heads/main@{#1148114} --- .../browser/safe_browsing/safe_browsing_blocking_page_test.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc index b0dc148648e1e..f52dcf3104221 100644 --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc @@ -3376,8 +3376,9 @@ IN_PROC_BROWSER_TEST_P(SafeBrowsingFencedFrameBrowserTest, UnsafeFencedFrame) { } // This test is modeled after IframeOptInAndReportThreatDetails above. +// TODO(https://crbug.com/1445499): Flaky IN_PROC_BROWSER_TEST_P(SafeBrowsingFencedFrameBrowserTest, - FencedFrameInThreatDetails) { + DISABLED_FencedFrameInThreatDetails) { SetExtendedReportingPrefForTests(browser()->profile()->GetPrefs(), true); const bool expect_threat_details = SafeBrowsingBlockingPage::ShouldReportThreatDetails(GetThreatType());