Skip to content
Permalink
Browse files

Remove support for the obsolete <isindex> tag.

This patch removes all special-casing for the <isindex> tag; it
now behaves exactly like <foo> in all respects. This additionally
means that we can remove the special-casing for forms containing
<input name="isindex"> as their first element.

The various tests for <isindex> have been deleted, with the
exception of the imported HTML5Lib tests. It's not clear that
we should send them patches to remove the <isindex> tests, at
least not while the element is (an obsolete) part of HTML5, and
supported by other vendors.

I've just landed failing test results here. That seems like
the right thing to do.

"Intent to Remove" discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/14q_I06gwg8/0a3JI0kjbC0J

Review URL: https://codereview.chromium.org/96653004

git-svn-id: svn://svn.chromium.org/blink/trunk@168010 bbb929c8-8fbe-4397-9dbb-9b2b20218538
  • Loading branch information
mkwst@chromium.org
mkwst@chromium.org committed Feb 27, 2014
1 parent d9212fe commit dfd5125a0002df42aa6c6133b3aa591953880f4e
Showing with 462 additions and 777 deletions.
  1. +2 −0 third_party/WebKit/LayoutTests/TestExpectations
  2. +0 −3 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement01-expected.txt
  3. +0 −14 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement01.html
  4. +0 −122 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement01.js
  5. +0 −3 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement02-expected.txt
  6. +0 −14 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement02.html
  7. +0 −119 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement02.js
  8. +0 −3 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement03-expected.txt
  9. +0 −14 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement03.html
  10. +0 −114 third_party/WebKit/LayoutTests/dom/html/level2/html/HTMLIsIndexElement03.js
  11. +0 −2 third_party/WebKit/LayoutTests/fast/dom/HTMLElement/ie-forbids-insert-html-expected.txt
  12. +1 −1 third_party/WebKit/LayoutTests/fast/dom/HTMLElement/ie-forbids-insert-html.html
  13. +0 −1 third_party/WebKit/LayoutTests/fast/dom/isindex-001.html
  14. +0 −4 third_party/WebKit/LayoutTests/fast/dom/isindex-002.html
  15. +0 −1 third_party/WebKit/LayoutTests/fast/events/resources/tabindex-focus-blur-all-frame1.html
  16. +0 −1 third_party/WebKit/LayoutTests/fast/events/resources/tabindex-focus-blur-all-frame2.html
  17. +0 −1 third_party/WebKit/LayoutTests/fast/events/resources/tabindex-focus-blur-all-iframe1.html
  18. +0 −1 third_party/WebKit/LayoutTests/fast/events/resources/tabindex-focus-blur-all-iframe2.html
  19. +0 −1 third_party/WebKit/LayoutTests/fast/events/resources/tabindex-focus-blur-all.js
  20. +0 −11 third_party/WebKit/LayoutTests/fast/forms/isindex-name-expected.txt
  21. +0 −21 third_party/WebKit/LayoutTests/fast/forms/isindex-name.html
  22. +0 −11 third_party/WebKit/LayoutTests/fast/forms/isindex-placeholder-expected.html
  23. +0 −10 third_party/WebKit/LayoutTests/fast/forms/isindex-placeholder.html
  24. +0 −9 third_party/WebKit/LayoutTests/fast/forms/text-style-color.html
  25. +1 −1 third_party/WebKit/LayoutTests/fast/parser/fragment-parser-expected.txt
  26. +1 −1 third_party/WebKit/LayoutTests/fast/parser/script-tests/fragment-parser.js
  27. +0 −7 third_party/WebKit/LayoutTests/fast/replaced/table-percent-height-text-controls.html
  28. +62 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-isindex-data-expected.txt
  29. +62 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-isindex-write-expected.txt
  30. +112 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-data-expected.txt
  31. +112 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-tests19-write-expected.txt
  32. +24 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-tests2-data-expected.txt
  33. +24 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-tests2-write-expected.txt
  34. +17 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-webkit02-data-expected.txt
  35. +17 −1 third_party/WebKit/LayoutTests/html5lib/generated/run-webkit02-write-expected.txt
  36. +0 −4 third_party/WebKit/LayoutTests/http/tests/misc/isindex-formdata-expected.txt
  37. +0 −42 third_party/WebKit/LayoutTests/http/tests/misc/isindex-formdata.html
  38. +0 −12 third_party/WebKit/LayoutTests/http/tests/misc/isindex-with-no-form-base-href-expected.txt
  39. +0 −14 third_party/WebKit/LayoutTests/http/tests/misc/isindex-with-no-form-base-href.html
  40. +0 −7 third_party/WebKit/LayoutTests/http/tests/misc/isindex-with-no-form-expected.txt
  41. +0 −44 third_party/WebKit/LayoutTests/http/tests/misc/isindex-with-no-form.html
  42. +0 −5 ...rty/WebKit/LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt
  43. +15 −76 third_party/WebKit/LayoutTests/platform/win/fast/forms/text-style-color-expected.txt
  44. +0 −5 ...rty/WebKit/LayoutTests/platform/win/fast/replaced/table-percent-height-text-controls-expected.txt
  45. +5 −5 third_party/WebKit/Source/core/css/html.css
  46. +1 −1 third_party/WebKit/Source/core/css/themeChromium.css
  47. +1 −6 third_party/WebKit/Source/core/html/FormDataList.cpp
  48. +0 −1 third_party/WebKit/Source/core/html/HTMLElement.cpp
  49. +0 −1 third_party/WebKit/Source/core/html/parser/HTMLStackItem.h
  50. +0 −47 third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
  51. +1 −1 third_party/WebKit/Source/devtools/front_end/ElementsTreeOutline.js
  52. +4 −8 third_party/WebKit/Source/web/WebSearchableFormData.cpp
@@ -36,6 +36,8 @@ crbug.com/344238 virtual/deferred/inspector/timeline/timeline-auto-record.html [
crbug.com/346119 virtual/deferred/inspector/timeline/timeline-start-time.html [ Pass Failure ]
crbug.com/346119 inspector/timeline/timeline-start-time.html [ Pass Failure ]

Bug(mkwst) fast/forms/text-style-color.html [ NeedsRebaseline ]

# -----------------------------------------------------------------
# Plugin tests
# -----------------------------------------------------------------

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit dfd5125

Please sign in to comment.
You can’t perform that action at this time.