From e641d7f04a4fe35163dcc095e4d2c874e77bd9cd Mon Sep 17 00:00:00 2001 From: Anthony Cui Date: Sat, 20 May 2023 02:35:57 +0000 Subject: [PATCH] [Translate metrics cleanup] Remove Translate.CompactInfobar.TranslationsPerPage code Most of this was already done on https://crbug.com/1244705 but there is a bit of remaining code to be removed. Bug: 1446386 Change-Id: I4ad7e655b408d48c89e9c592ced15ac851508379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545119 Reviewed-by: Robbie McElrath Reviewed-by: Megan Jablonski Reviewed-by: Matthew Jones Commit-Queue: Anthony Cui Cr-Commit-Position: refs/heads/main@{#1146831} --- .../chrome/browser/infobar/TranslateCompactInfoBar.java | 3 --- ios/chrome/browser/translate/translate_constants.h | 1 - ios/chrome/browser/translate/translate_constants.mm | 2 -- .../org/chromium/weblayer_private/TranslateCompactInfoBar.java | 3 --- 4 files changed, 9 deletions(-) diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java index fe75f0f3c63304..ed9e293de00aec 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java @@ -66,9 +66,6 @@ public class TranslateCompactInfoBar private long mNativeTranslateInfoBarPtr; private TranslateTabLayout mTabLayout; - // Metric to track the total number of translations in a page, including reverts to original. - private int mTotalTranslationCount; - private static final String INFOBAR_HISTOGRAM = "Translate.CompactInfobar.Event"; // Need 2 instances of TranslateMenuHelper to prevent a race condition bug which happens when diff --git a/ios/chrome/browser/translate/translate_constants.h b/ios/chrome/browser/translate/translate_constants.h index 626b2afcc39c7c..60e01720af2505 100644 --- a/ios/chrome/browser/translate/translate_constants.h +++ b/ios/chrome/browser/translate/translate_constants.h @@ -22,6 +22,5 @@ typedef NS_OPTIONS(NSUInteger, UserAction) { // UMA histogram names. // Note: These string constants are repeated in TranslateCompactInfoBar.java. extern const char kEventHistogram[]; -extern const char kTranslationCountHistogram[]; #endif // IOS_CHROME_BROWSER_TRANSLATE_TRANSLATE_CONSTANTS_H_ diff --git a/ios/chrome/browser/translate/translate_constants.mm b/ios/chrome/browser/translate/translate_constants.mm index cb437df41d032e..da1789e9c417a3 100644 --- a/ios/chrome/browser/translate/translate_constants.mm +++ b/ios/chrome/browser/translate/translate_constants.mm @@ -9,5 +9,3 @@ #endif const char kEventHistogram[] = "Translate.CompactInfobar.Event"; -const char kTranslationCountHistogram[] = - "Translate.CompactInfobar.TranslationsPerPage"; diff --git a/weblayer/browser/java/org/chromium/weblayer_private/TranslateCompactInfoBar.java b/weblayer/browser/java/org/chromium/weblayer_private/TranslateCompactInfoBar.java index 67a95265266e9b..dd42909e719261 100644 --- a/weblayer/browser/java/org/chromium/weblayer_private/TranslateCompactInfoBar.java +++ b/weblayer/browser/java/org/chromium/weblayer_private/TranslateCompactInfoBar.java @@ -59,9 +59,6 @@ public class TranslateCompactInfoBar extends InfoBar private long mNativeTranslateInfoBarPtr; private TranslateTabLayout mTabLayout; - // Metric to track the total number of translations in a page, including reverts to original. - private int mTotalTranslationCount; - // Histogram names for logging metrics. private static final String INFOBAR_HISTOGRAM = "Translate.CompactInfobar.Event";